Closed Bug 334936 Opened 19 years ago Closed 18 years ago

move main communicator chrome to suite/

Categories

(SeaMonkey :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0a1

People

(Reporter: kairo, Assigned: kairo)

References

Details

Attachments

(2 files, 2 obsolete files)

bug 333383 and bug 334877 move chrome://communicator/ files that reside in xpfe/components to suite/ - in this part I'll move the main xpfe/communicator/ chrome.
Attached patch jar.mn changes for main communicator/ move (obsolete) (deleted) — Splinter Review
Here are the jar.mn changes that move all of the xpfe/communicator chrome to suite/ - at least for MOZ_SUITE, that is. I've included the branding files, as those are in xpfe/communicator/ as well currently. The patch is against a state of suite/ jar.mn files that is reached after applying bug 334877. Once this + the cvsmoves are in, xpfe/communicator chrome is only built for non-suite apps (thunderbird, not sure what else), so all suite-specific cruft can be removed from there.
Attachment #219328 - Flags: superreview?(neil)
Attachment #219328 - Flags: review?(neil)
Attached patch cvsmoves for xpfe/communicator chrome (obsolete) (deleted) — Splinter Review
...and those are the cvsmoves/copies needed along with above patch. As files are actually copied, we'll just not cvs remove the files that stay still referenced in xpfe/communciator/jar.mn for use with thunderbird.
Attachment #219330 - Flags: superreview?(neil)
Attachment #219330 - Flags: review?(neil)
Comment on attachment 219328 [details] [diff] [review] jar.mn changes for main communicator/ move Nit: you don't need to specify file names of files in the jar.mn directory.
This has suffered from a bit of bitrot from the addition of new suiterunner overlays, here's an un-bitrotted version, once again diffed against the result of bug 334877
Attachment #219328 - Attachment is obsolete: true
Attachment #222405 - Flags: superreview?(neil)
Attachment #222405 - Flags: review?(neil)
Attachment #219328 - Flags: superreview?(neil)
Attachment #219328 - Flags: review?(neil)
Attachment #219330 - Flags: superreview?(neil)
Attachment #219330 - Flags: superreview+
Attachment #219330 - Flags: review?(neil)
Attachment #219330 - Flags: review+
Attachment #222405 - Flags: superreview?(neil)
Attachment #222405 - Flags: superreview+
Attachment #222405 - Flags: review?(neil)
Attachment #222405 - Flags: review+
Depends on: 338438
Comment on attachment 219330 [details] [diff] [review] cvsmoves for xpfe/communicator chrome communicatorOverlay.xul is obsolete now, attaching an updated file to the cvs copy bug.
Attachment #219330 - Attachment is obsolete: true
Checked in, leaving this open until I know it works and I've cvs removed the now unused files (those that are not referenced in the jar.mn any more)
This is the list of files that were obsoleted by this bug, and were cvs removed a moment ago.
FIXED, finally ;-)
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: