I thought this bug existed... guess not. Need to land support for Search Suggestions, which is a Google Suggest-like feature that any search engine can support. Details will be on the wiki soon for how other providers can support this.

Discussed in triage call, want to take this for a2

Comment on attachment 221353 [details] [diff] [review] implement remote suggestion autocomplete - _createSuggestionURI needs to null-check suggestionURI - wouldn't hurt to bump nsISearchEngine's UUID, but I guess it doesn't matter - typo s/nsIAutoComleteResult/nsIAutoCompleteResult/ - sandboxHost is unused (meant to be used instead of "http://www.mozilla.org", I'm guessing) - indent is weird around |+ this._textbox.mController.input = this._textbox;| - don't use the os namespace for the added suggestionURL in the plugin files since it's not OpenSearch - nit: a lot of trailing whitespace, s/ \n/\n/g ;)

Comment on attachment 221353 [details] [diff] [review] implement remote suggestion autocomplete approved at bon echo triage call

Shazam.

Comment on attachment 221365 [details] [diff] [review] update installer manifests too landed this on the branch.

Without this we leak all browser windows

Comment on attachment 221402 [details] [diff] [review] Fix leak can you add a comment saying we leak the world if we don't null this? call it a hunch...

*** Bug 335439 has been marked as a duplicate of this bug. ***

Gavin, is there more to come ? It doesn't work at all for Google/Yahoo (or any other searchengine) Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060515 Minefield/3.0a1 ID:2006051510 [cairo] same result on a non-cairo build

Oh, looks like the installer manifest changes weren't landed, so installer builds won't work. I'll do that in a sec.

mozilla/browser/installer/windows/packages-static 1.75 mozilla/browser/installer/unix/packages-static 1.70

(In reply to comment #13) >so installer builds won't work. I'll do that in a sec. > I'm on .zip's

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060515 Minefield/3.0a1 ID:2006051514 verified I filed 338064 for the pref issue

Search suggestion don't support 2byte language such as CJK right now. It's different to detect finishing syllables. e.x onKeyUp and onKeyDown in JavaScript. So Google made 2 byte langunage version. http://www.google.co.jp/webhp?complete=1&hl=ja

Channy, thanks for pointing this out (and making such a nice demo film!)--please open it as a separate bug rather than reopening this one.

I made a new bug https://bugzilla.mozilla.org/show_bug.cgi?id=338585