User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008012304 Minefield/3.0b3pre Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008012304 Minefield/3.0b3pre After opening and closing a new window when the urlbar is focused, urlbar autocomplete doesn't work. Typing a URL and pressing enter won't load this site either. You have to enter a complete site name and hit the GO button. After that, the urlbar begins working like normal again. Reproducible: Always Steps to Reproduce: 1.Click on the urlbar to focus it 2.Open a new window, either by clicking the toolbar button, or through File->New Window 3.Close the new window 4.Begin typing in the urlbar of the original window Actual Results: No autocomplete is shown. Enter does nothing. Expected Results: Autocomplete results should show. Enter should load the site that you've typed. I don't know that this is a common set of actions, so I'm not sure how to rate the severity of this bug.

Confirmed, with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2008012407 Minefield/3.0b3pre

Regression window is http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2006-05-15+05%253A00&maxdate=2006-05-15+11%253A00 Bug 337586, Bug 337520 or Bug 337219?

Windows only? Can't reproduce on linux.

Pretty severe, as it happens anytime you close one window and return to the next.

Could anyone (on Windows) test backing out those bugs?

(In reply to comment #4) > Pretty severe, as it happens anytime you close one window and return to the > next. > Just to be clear, it only happens if the URL bar is focused in the back window, when you close the new window. I don't know quite how to write that and have it make sense, but if I don't play with the url bar at all while I open and close a new window, everything is fine.

Neither of those patches back out cleanly, I guess I could pull by date...

Seeing on beta5rc2 on Mac 10.4 (ppc) but not on same build on Linux FC7

(In reply to comment #5) > Could anyone (on Windows) test backing out those bugs? I suggest using --fuzz=somenumber when trying to back out those patches. I don't have windows development machine so can't really test this :(

Workaround for beta4: Click somewhere else and refocus the location bar.

Er.. right we're on beta 5 :p

gavin: So the problem comes from.. 1) opening a new window causes a new input to be attached to the controller 2) closing the window removes the attached input 3) the original window's input isn't attached anymore 4) refocusing the input fixes the problem because it reattaches the input

Comment on attachment 312114 [details] [diff] [review] v1 r=me as a workaround, but can you file a bug on the core regression that broke this? I want to figure that out, even if it has to wait until Firefox 3 ships :/

(In reply to comment #14) > can you file a bug on the core regression that broke this? Filed bug 426425. Checking in toolkit/content/widgets/autocomplete.xml; /cvsroot/mozilla/toolkit/content/widgets/autocomplete.xml,v <-- autocomplete.xml new revision: 1.132; previous revision: 1.131 done

Verified. Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9pre) Gecko/2008040204 Minefield/3.0pre ID:2008040204 Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008040204 Minefield/3.0pre

Potentially causing other problems like bug 426525 which apparently gets fixed when backing out v1.

Back out v1 and fix search binding.

So this fixes the regression caused by bug 337178 which was in the indicated regression range.

This build has patch v2 applied -- should fix this bug and not cause bug 426525. https://build.mozilla.org/tryserver-builds/2008-04-05_02:17-edward.lee@engineering.uiuc.edu-urlbar/

Checking in browser/components/search/content/search.xml; /cvsroot/mozilla/browser/components/search/content/search.xml,v <-- search.xml new revision: 1.124; previous revision: 1.123 done Checking in toolkit/content/widgets/autocomplete.xml; /cvsroot/mozilla/toolkit/content/widgets/autocomplete.xml,v <-- autocomplete.xml new revision: 1.135; previous revision: 1.134 done

in-litmus+: https://litmus.mozilla.org/show_test.cgi?id=5312

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008050104 Minefield/3.0pre ID:2008050104 and with the appropriate Windows build.