Closed
Bug 338097
Opened 19 years ago
Closed 18 years ago
DOM Inspector: remove license with preprocessor (patch)
Categories
(Other Applications :: DOM Inspector, defect)
Other Applications
DOM Inspector
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: piratepenguin, Unassigned)
Details
Attachments
(1 file, 1 obsolete file)
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20060418 Firefox/1.5
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8) Gecko/20060418 Firefox/1.5
Change the license block so it doesn't end up in all those files (it's removed by the preprocessor)...
This'll result in a smaller download/installation.
Reproducible: Always
Reporter | ||
Comment 1•19 years ago
|
||
Reporter | ||
Comment 2•19 years ago
|
||
this one actually modifies jar.mn so the files are run through the preprocessor.
Attachment #222142 -
Attachment is obsolete: true
Updated•19 years ago
|
Assignee: nobody → dom-inspector
Component: General → DOM Inspector
Product: Firefox → Other Applications
QA Contact: general → timeless
Comment 3•18 years ago
|
||
You need to request a review when you submit a patch. Any chance on this getting updated?
Reporter | ||
Comment 4•18 years ago
|
||
(In reply to comment #3)
> You need to request a review when you submit a patch. Any chance on this
> getting updated?
>
I spoke to timeless on IRC when I submitted the bug and he was talking about invalidating it because it'd be slower to compile etc.
I'd be more interested atm in having an option at compile time to strip out all the whitespace and comments from the markup using the 'strip' program in the attachment of Bug 68686.
Comment 5•18 years ago
|
||
(In reply to comment #4)
> I spoke to timeless on IRC when I submitted the bug and he was talking about
> invalidating it because it'd be slower to compile etc.
Could you come up with some numbers to compare compile times before and after?
FWIW, bug 279698 and bug 309418 deal with this issue for other areas of code.
i'm going to put on my module owner hat and wontfix this.
the compression (zip, whatever) reduces the download size. this just wastes time while building.
Status: UNCONFIRMED → RESOLVED
Closed: 18 years ago
Resolution: --- → WONTFIX
Updated•17 years ago
|
Assignee: dom-inspector → nobody
QA Contact: timeless → dom-inspector
You need to log in
before you can comment on or make changes to this bug.
Description
•