Closed
Bug 338879
Opened 19 years ago
Closed 19 years ago
Method from scriptable nsIWSPInterfaceInfoService returns non-scriptable nsIInterfaceInfo
Categories
(Core Graveyard :: Web Services, defect)
Core Graveyard
Web Services
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jhpedemonte, Assigned: jhpedemonte)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
jst
:
review+
jst
:
superreview+
jst
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
The sole method of scriptable interface nsIWSPInterfaceInfoService returns the non-scriptable interface nsIInterfaceInfo. It also takes as a parameter the non-scriptable interface nsIInterfaceInfoManager. This interface should not be scriptable, since none of the "scriptable" languages can make use of it.
|
Assignee | |
Comment 1•19 years ago
|
||
|
|
Assignee | |
Updated•19 years ago
|
Flags: blocking1.9a2?
|
|
Assignee | |
Comment 2•19 years ago
|
||
In bug 338876, Darin brings up a good point: "perhaps the method should be made noscript. the interface itself can still be used from script... script can call QueryInterface. we shouldn't prevent script from passing around interfaces as variables just because they don't have any scriptable methods." This patch does just that.
Attachment #222929 -
Attachment is obsolete: true
Attachment #222936 -
Flags: review?(jst)
Attachment #222929 -
Flags: review?(jst)
|
||
Comment 3•19 years ago
|
||
Comment on attachment 222936 [details] [diff] [review]
patch v2
r+sr=jst
Attachment #222936 -
Flags: superreview+
Attachment #222936 -
Flags: review?(jst)
Attachment #222936 -
Flags: review+
|
|
Assignee | |
Comment 4•19 years ago
|
||
Checked in to trunk. ->FIXED
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•19 years ago
|
||
Comment on attachment 222936 [details] [diff] [review]
patch v2
Asking for 1.8.1 approval. I'd like to get as many of these interface bugs on the branch, for use in the next version of xulrunner.
Attachment #222936 -
Flags: approval-branch-1.8.1?(jst)
|
|
||
Updated•19 years ago
|
Attachment #222936 -
Flags: approval-branch-1.8.1?(jst) → approval-branch-1.8.1+
|
|
Assignee | |
Updated•19 years ago
|
Keywords: fixed1.8.1
|
||
Updated•7 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•