The following change to install_sub.pl uses a hard coded path to a firefox file: http://lxr.mozilla.org/mozilla/source/toolkit/mozapps/installer/windows/install_sub.pl#304 system("upx --best -o $dosDistInstall/nsis/7zSD.sfx $dostopsrcdir/other-licenses/7zstub/firefox/7zSD.sfx") This makes it hard for the upx command to run on thunderbird's version of 7zSD.sfx. Fortunately, we already have an environment variable with the path to 7zSD.sfx already available to us because we had this same issue with the old installer. Patch coming up.

This patch makes us use 7ZipSFXModule for the path to 7zSD.sfx. This environment variable is already used by the old installer in install_sub.pl and installer.cfg for toolkit apps.

Comment on attachment 223380 [details] [diff] [review] the fix >Index: browser/installer/windows/nsis/defines.nsi.in >=================================================================== >RCS file: /cvsroot/mozilla/browser/installer/windows/nsis/defines.nsi.in,v >retrieving revision 1.1 >diff -u -w -r1.1 defines.nsi.in >--- browser/installer/windows/nsis/defines.nsi.in 22 May 2006 22:29:44 -0000 1.1 >+++ browser/installer/windows/nsis/defines.nsi.in 25 May 2006 22:53:26 -0000 >@@ -14,3 +14,4 @@ > !define URLUpdateInfo "http://www.mozilla.org/products/firefox/" > !define WindowClass "FirefoxMessageWindow" > !define SurveyURL "https://survey.mozilla.com/1/Mozilla%20Firefox/${AppVersion}%20(${AB_CD})/exit.html" >+!define 7ZipSFXModule "other-licenses/7zstub/firefox/7zSD.sfx" This isn't used and doesn't need to be added. r=me with that removed.

Fixed on trunk

Comment on attachment 223838 [details] [diff] [review] patch as checked in Can we get it on the branch too Rob? Thanks for checking this in for me.

Fixed on the 1.8.1 branch