Closed
Bug 341277
Opened 18 years ago
Closed 18 years ago
assertion loading any URL that's not in bookmarks
Categories
(Firefox :: Bookmarks & History, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2 beta1
People
(Reporter: dbaron, Assigned: Gavin)
References
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
(deleted),
patch
|
mconnor
:
review+
mconnor
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
Running a debug build of Firefox on the MOZILLA_1_8_BRANCH asserts every time I load a URL that's not in my bookmarks, with the following stack:
###!!! ASSERTION: null ptr: 'aSource != nsnull', file /builds/1.8/mozilla/browser/components/bookmarks/src/nsBookmarksService.cpp, line 3125
Break: at file /builds/1.8/mozilla/browser/components/bookmarks/src/nsBookmarksService.cpp, line 3125
nsDebugImpl::Break(char const*, int) (/builds/1.8/mozilla/xpcom/base/nsDebugImpl.cpp:319)
nsDebugImpl::Assertion(char const*, char const*, char const*, int) (/builds/1.8/mozilla/xpcom/base/nsDebugImpl.cpp:268)
NSGlue_Assertion (/builds/1.8/obj/firefox-debugopt/xpcom/build/nsDebug.cpp:107)
nsBookmarksService::IsBookmarkedResource(nsIRDFResource*, int*) (/builds/1.8/mozilla/browser/components/bookmarks/src/nsBookmarksService.cpp:3125)
nsBookmarksService::GetSynthesizedType(nsIRDFResource*, nsIRDFNode**) (/builds/1.8/mozilla/browser/components/bookmarks/src/nsBookmarksService.cpp:3401)
nsBookmarksService::RequestCharset(nsIWebNavigation*, nsIChannel*, int*, nsISupports**, nsACString_internal&) (/builds/1.8/mozilla/browser/components/bookmarks/src/nsBookmarksService.cpp:3479)
nsHTMLDocument::TryBookmarkCharset(nsIDocShell*, nsIChannel*, int&, nsACString_internal&) (/builds/1.8/mozilla/content/html/document/src/nsHTMLDocument.cpp:534)
nsHTMLDocument::StartDocumentLoad(char const*, nsIChannel*, nsILoadGroup*, nsISupports*, nsIStreamListener**, int, nsIContentSink*) (/builds/1.8/mozilla/content/html/document/src/nsHTMLDocument.cpp:819)
...
Either there's a problem or there's a bogus assertion; we should figure out which and fix it.
|
Reporter | |
Updated•18 years ago
|
Flags: blocking-firefox2?
|
Assignee | |
Comment 1•18 years ago
|
||
This is almost certainly due to bug 284660, I will look into it later today when I get back home.
|
|
Assignee | |
Comment 2•18 years ago
|
||
Looks like http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/components/bookmarks/src/nsBookmarksService.cpp&rev=1.67.2.10&mark=3475#3447 needs a " || (rv == NS_RDF_NO_VALUE)".
|
|
Assignee | |
Comment 3•18 years ago
|
||
Or a null check, and really it should return NS_ERROR_FAILURE and not NS_RDF_NO_VALUE in that case.
|
|
Assignee | |
Comment 4•18 years ago
|
||
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #225356 -
Flags: review?(mconnor)
Attachment #225356 -
Flags: approval-branch-1.8.1?(mconnor)
|
|
Assignee | |
Updated•18 years ago
|
Whiteboard: [patch-r?]
|
||
Updated•18 years ago
|
Attachment #225356 -
Flags: review?(mconnor)
Attachment #225356 -
Flags: review+
Attachment #225356 -
Flags: approval-branch-1.8.1?(mconnor)
Attachment #225356 -
Flags: approval-branch-1.8.1+
|
|
Assignee | |
Updated•18 years ago
|
Whiteboard: [patch-r?] → [checkin needed (1.8 branch)]
|
|
Assignee | |
Comment 5•18 years ago
|
||
mozilla/browser/components/bookmarks/src/nsBookmarksService.cpp 1.67.2.12
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Flags: blocking-firefox2?
Keywords: fixed1.8.1
OS: Linux → All
Hardware: PC → All
Resolution: --- → FIXED
Whiteboard: [checkin needed (1.8 branch)]
Target Milestone: --- → Firefox 2 beta1
You need to log in
before you can comment on or make changes to this bug.
Description
•