file version: 4.0.0.0 internal name: JS3240 original filename: js3240.dll product version: 4.0 given that the js3250 is js1.6 or 1.7 which doesn't match what js3240 offered, we really should fix this. http://landfill.mozilla.org/mxr-test/seamonkey/search?string=js3240&find=js/src /js/src/js3240.rc, line 40 -- VALUE "InternalName", "JS3240\0" /js/src/js3240.rc, line 43 -- VALUE "OriginalFilename", "js3240.dll\0" /js/src/resource.h, line 3 -- // Used by js3240.rc I think it's time for js3250.rc

I think there are legal issues as to how much freedom we have to change these strings. Mitchell, can you please look and give us some guidance on changing the copyright etc. 37 VALUE "CompanyName", "Netscape Communications Corporation\0" 38 VALUE "FileDescription", "Netscape 32-bit JavaScript Module\0" 39 VALUE "FileVersion", "4.0\0" 40 VALUE "InternalName", "JS3240\0" 41 VALUE "LegalCopyright", "Copyright Netscape Communications. 1994-96\0" 42 VALUE "LegalTrademarks", "Netscape, Mozilla\0" 43 VALUE "OriginalFilename", "js3240.dll\0" 44 VALUE "ProductName", "NETSCAPE\0" 45 VALUE "ProductVersion", "4.0\0"

If somebody can decide what the values for FileVersion/ProductVersion/FileDescription should be we can use the Mozilla defaults for the rest. Or we could simply remove these custom values and use the mozilla defaults for all values... unless this file is also used in the Makefile.ref build.

oops, forgot to cc mitchell. See comment 2.

We have a standard copyright statement... I will make this one match it when the other decisions are made.

(In reply to comment #3) > If somebody can decide what the values for > FileVersion/ProductVersion/FileDescription should be we can use the Mozilla > defaults for the rest. Or we could simply remove these custom values and use > the mozilla defaults for all values... unless this file is also used in the > Makefile.ref build. Please lets get this moving, it seems nobody cares about these values. js3240.rc is not used by Makefile.ref, the DLL built that way doesn't have any version information.

I'm going to hold off of this until bug 97954 has landed, to avoid merge conflict pain.