Open Bug 520849 Opened 15 years ago Updated 2 years ago

no version info in mozjs.dll

Categories

(Firefox Build System :: General, defect)

x86
Windows XP
defect

Tracking

(Not tracked)

People

(Reporter: ted, Unassigned)

References

Details

Attachments

(1 obsolete file)

Since bug 341901 landed we don't have *any* version info in the JS dll. This is bad, we should have the default Mozilla stuff, if nothing else.
Attached patch Implement versioning (obsolete) (deleted) — Splinter Review
This patch adjusts configure to set version vars from milestone.txt (same as all other sections of the codebase), sets the LIBRARY_NAME to contain major.minor version, installs headers into a version-specific subdir, adjusts js-config generation appropriately for all changes, and adds generation of a pkg-config .pc file (currently installed only on linux, but please add for all arches that are appropriate). This patch corresponds nicely with the symbol-versioning patch found in attachment 681995 [details] [diff] [review] Patch also addresses bug 481878
Attachment #682018 - Flags: review?(ted)
..forgot; patch also sets a variable NSPR_MINVER in configure, so that the configure checks for external NSPR will propagate through to the 'Requires:' section of the .pc file.
Comment on attachment 682018 [details] [diff] [review] Implement versioning ... reviewed on IRC with ted, this fix isn't appropriate to this particular bug. Dunno how to remove attachments, but i'll stop usurping the bug now and use bug 812265 instead This bug might be appropriate to depend on the solution here, though, given version info is made available within the js/src build system.
Attachment #682018 - Flags: review?(ted)
Attachment #682018 - Attachment is obsolete: true
Product: Core → Firefox Build System
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: