Closed
Bug 342155
Opened 19 years ago
Closed 19 years ago
[trunk] open in tabs is busted.
Categories
(Firefox :: Tabbed Browser, defect)
Firefox
Tabbed Browser
Tracking
()
VERIFIED
FIXED
Firefox 2 beta1
People
(Reporter: fredbezies, Assigned: dietrich)
References
Details
(Keywords: regression, verified1.8.1)
Attachments
(1 file)
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060620 Firefox/3.0a1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060620 Firefox/3.0a1
Simple. When I try to activate 'open in tabs", nothing happens, but I have this error line in Error Console :
Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMXULElement.boxObject]" nsresult: "0x80004005 (NS_ERROR_FAILURE)" location: "JS frame :: chrome://global/content/bindings/browser.xml :: get_docShell :: line 0" data: no]
Worked in a one day old build.
Reproducible: Always
Steps to Reproduce:
1.Get a recent nightly, today's is better
2.Launch it
3.Try open in tabs
Actual Results:
nothing
Expected Results:
tabs opened.
Using an homemade build, based on code up-to-date a 03:00 am, mozilla.org time.
Related to bugfix for bug 254021 ?!
Reporter | ||
Updated•19 years ago
|
Keywords: regression
Version: unspecified → Trunk
Reporter | ||
Comment 1•19 years ago
|
||
Also have this error, but I don't know if it is related :
Error: tabbrowser.mTabs[i] has no properties
Source File: file:///home/fred/Applications/firefox/components/nsSessionStore.js
Line: 816
Comment 2•19 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060620 Minefield/3.0a1 ID:2006062004 [cairo]
Confirming on win. Regression between 2006061923 and 2006062004.
Assignee | ||
Updated•19 years ago
|
Assignee: nobody → dietrich
Assignee | ||
Updated•19 years ago
|
Blocks: undoclosetab
Comment 3•19 years ago
|
||
(In reply to comment #2)
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060620
> Minefield/3.0a1 ID:2006062004 [cairo]
>
> Confirming on win. Regression between 2006061923 and 2006062004.
WFM Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060620 Minefield/3.0a1 ID:2006062004 [cairo] with both my regular and a clean profile.
I tested Bookmarks Menu -> Folder -> Open in Tabs, Right-click on a link -> open in tab
Reporter | ||
Comment 4•19 years ago
|
||
Tabs are opened on the 1st try after launching firefox, and after, no more opened.
Weird.
Comment 5•19 years ago
|
||
(In reply to comment #1)
> Also have this error, but I don't know if it is related :
>
> Error: tabbrowser.mTabs[i] has no properties
> Source File:
> file:///home/fred/Applications/firefox/components/nsSessionStore.js
> Line: 816
>
I filed bug 342179 for that
Comment 6•19 years ago
|
||
Guessing from the regression window, this could be due to bug 338441 which got exposed by bug 337320 and should be fixed by bug 318168.
Regis: have you disabled SessionStore in any way?
Comment 7•19 years ago
|
||
(In reply to comment #6)
> Regis: have you disabled SessionStore in any way?
No, my pref settings are:
browser.sessionstore.resume_from_crash = true
browser.sessionstore.resume_session = true
browser.sessionstore.resume_session_once = false
I see the error from comment 1 too but not when I use "Open in Tabs".
Comment 8•19 years ago
|
||
(In reply to comment #7)
I forgot: those settings are like that in my regular profile.
Assignee | ||
Comment 9•19 years ago
|
||
Simon is correct, bug 318168 will fix this. I tested the patch in 318168 and it fixed this problem.
Depends on: tabbedbrowsing
Comment 10•19 years ago
|
||
> Simon is correct, bug 318168 will fix this. I tested the patch in 318168 and it
> fixed this problem.
working on getting reviews for #318168 now, but if you need to break out the simple changes to invalidate the _browers cache sooner, I can deal with the cvs conflits.
Assignee | ||
Updated•19 years ago
|
Whiteboard: [swag: .2d]
Assignee | ||
Comment 11•19 years ago
|
||
This is the subset of the patch for bug 318618 which Simon broke out for bug 342179. It flushes the tabbrowser's browser cache (see comments 35-40 in bug 318618), and fixes this bug.
Attachment #226656 -
Flags: review?(mconnor)
Updated•19 years ago
|
OS: Linux → All
Hardware: PC → All
Comment 12•19 years ago
|
||
*** Bug 342706 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 13•19 years ago
|
||
Re comment #11(In reply to comment #11)
> Created an attachment (id=226656) [edit]
> patch from bug 342179
>
> This is the subset of the patch for bug 318618 which Simon broke out for bug
> 342179. It flushes the tabbrowser's browser cache (see comments 35-40 in bug
> 318618), and fixes this bug.
>
Sorry, that's bug 318168, not bug 318618.
Flags: blocking-firefox2?
Target Milestone: --- → Firefox 2 beta1
Updated•19 years ago
|
Attachment #226656 -
Flags: review?(mconnor) → review+
Updated•19 years ago
|
Flags: blocking-firefox2? → blocking-firefox2+
Assignee | ||
Comment 14•19 years ago
|
||
Fixed by bug 318168
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•19 years ago
|
Keywords: fixed1.8.1
Whiteboard: [swag: .2d]
Comment 15•19 years ago
|
||
*** Bug 343075 has been marked as a duplicate of this bug. ***
Comment 16•18 years ago
|
||
Verified fixed with Windows, Mac and Linux with 2.0.b1rc3 builds
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1 → verified1.8.1
You need to log in
before you can comment on or make changes to this bug.
Description
•