Closed
Bug 342179
Opened 18 years ago
Closed 18 years ago
close a tab -> Error: tabbrowser.mTabs[i] has no properties
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: Peter6, Assigned: dietrich)
References
Details
(Keywords: fixed1.8.1, Whiteboard: [swag: .5d])
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060620 Minefield/3.0a1 ID:2006062002 [cairo]
repro:
1.open FF
2.open an extra tab
3.close that tab
Error: tabbrowser.mTabs[i] has no properties
Source file: file:///C:/Programmas/Firefox/ff30C/firefox/components/nsSessionStore.js
Line: 816
followed by
Error: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMXULElement.boxObject]
Source file: chrome://global/content/bindings/browser.xml
Comment 1•18 years ago
|
||
This sounds to me like the regression of bug 338441 which should get fixed with bug 318168.
Reporter | ||
Updated•18 years ago
|
Summary: Error: tabbrowser.mTabs[i] has no properties → close a tab -> Error: tabbrowser.mTabs[i] has no properties
Comment 2•18 years ago
|
||
Facing in under ubuntu 6.06 LTS.
OS -> All ?
Reporter | ||
Comment 3•18 years ago
|
||
(In reply to comment #1)
> This sounds to me like the regression of bug 338441 which should get fixed with
> bug 318168.
>
it first showed up last night after bug 254021 was checked in though
Comment 4•18 years ago
|
||
This fixes the issue for me. I don't see how bug 254021 could have caused this without SessionStore being enabled, so it's probably rather due to bug 337320 (as mentioned in bug 342155).
Assignee | ||
Updated•18 years ago
|
Depends on: tabbedbrowsing
Comment 5•18 years ago
|
||
(In reply to comment #4)
> Created an attachment (id=226366) [edit]
> fix (see bug 318168)
>
> This fixes the issue for me. I don't see how bug 254021 could have caused this
> without SessionStore being enabled, so it's probably rather due to bug 337320
> (as mentioned in bug 342155).
>
SessionStore has been enabled on trunk for several days, and worked fine until 254021 was checked in.
Comment 6•18 years ago
|
||
Indeed. The problem is thus probably rather that SessionStore tries to capture the tab one last time while it's already being destroyed (however I don't see how that issue could be fixed before the new tab related events are added in bug 322898 or bug 318168).
Comment 7•18 years ago
|
||
I think this is related to something I've seen with bug #318168, in that we need to clear the _browsers cache. see bug #318168 comment #36.
Assignee: nobody → sspitzer
Comment 8•18 years ago
|
||
(In reply to comment #7)
I thought so, too, originally, but it in fact rather seems to be related to SessionStore trying to access a tab which has already been removed from mTabContainer. Apart of the _browsers fix, SessionStore must be able to observe the TabClose event and react to it (instead of DOMNodeRemoved) - see my comment #6.
Comment 9•18 years ago
|
||
based on simon's comments, re-assigning to dietrich.
Assignee: sspitzer → dietrich
Assignee | ||
Updated•18 years ago
|
Whiteboard: [swag: .5d]
Assignee | ||
Comment 10•18 years ago
|
||
Added dependency on bug 334839, which is for adding support for the new tab events to sessionstore, once they're available.
Status: NEW → ASSIGNED
Depends on: 334839
Assignee | ||
Comment 11•18 years ago
|
||
Fixed by bug 318168 and bug 334839.
You need to log in
before you can comment on or make changes to this bug.
Description
•