Closed Bug 343941 Opened 18 years ago Closed 18 years ago

Audit Localizable.strings (and other .strings files) for typos/style guide and clarity

Categories

(Camino Graveyard :: General, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Camino1.5

People

(Reporter: alqahira, Assigned: froodian)

References

Details

(Keywords: fixed1.8.1.1)

Attachments

(2 files)

(deleted), application/zip
alqahira
: review+
stuart.morgan+bugzilla
: superreview+
Details
(deleted), patch
alqahira
: review+
stuart.morgan+bugzilla
: superreview+
Details | Diff | Splinter Review
Just like we're doing with prefPanes, we need to audit the Localizable.strings files (there are multiple ones, as well as .strings files for Certifs and such) for typos/style guide issues and clarity. For instance, the pop-up strings are "popup" while the rest of the app is "pop-up". (The message there could maybe mention the Exceptions list to inform people of that feature, but it's already quite a long message...).
*** Bug 349415 has been marked as a duplicate of this bug. ***
Toolbar audit: - Replace all instances of "current page" with "this page" - Change "Close the current tab" to "Close this tab" - In "Open a new message in your mail program with the URL of the current page" s/URL/location - "Show recently visited pages organized by date" needs to lose the "organized by date" - "Fill fields on this web page with your Address Book information" needs to lose the "web" - Change "Go to home page" to ""Go to your home page" - Change "Show the download manager" to "Show the Downloads window"
Delete "CloseWindowWithMultipleTabsCheckboxLabel" = "Don’t show this warning again"; "QuitWithMultipleTabsCheckboxLabel" = "Don’t show this warning again"; And replace with "DontShowWarningAgainCheckboxLabel" = "Don’t show this warning again"; This will require minimal code changes as well.
This needs to get wrapped up soon. We don't want to be doing lots of strings changes at the last minute or it'll hurt localization.
The pop-up strings seem to be gone. Delete (as part of comment 3) "CloseMultipleWindowsCheckboxLabel" = "Don’t show this warning again"; Change: "Bookmark Manager" = "Bookmark Manager"; -> Bookmarks Manager per cbo style /* Error importing bookarks */ -> /* Error importing bookmarks */ - All instances of "web site" to "website" per cbo style (this is the only change I see that is needed in CertificateDialogs.strings, Privacy's loc.strings) - All instances of "occured" -> "occurred" - All instances of "MacOS X" -> "Mac OS X" - All instances of "accessibililty" -> "accessibility" I think the way to go about this is have someone (froodian) post updated .strings files for the 3 files that need changes, as well as the patch, and then seek review ("verification") on those.... If anyone else has .strings pet peeves, speak now....
Attached file New Strings files (deleted) —
- New Localizable.strings (in resources/localized/Eng) - New CertificateDialogs.strings - New Localizable.strings (for History prefpane) "web site" -> "website" - New Localizable.strings (for Privacy prefpane) "web site" -> "website" Other changes: All instances of "certificate authority" -> "Certificate Authority" (to match what most of them are already)
Assignee: nobody → stridey
Status: NEW → ASSIGNED
Attachment #244148 - Flags: review?(alqahira)
Attached patch String changes (deleted) — Splinter Review
Attachment #244149 - Flags: review?(alqahira)
Comment on attachment 244148 [details] New Strings files These look OK, except you missed deleting "QuitWithMultipleTabsCheckboxLabel" = "Don’t show this warning again"; from the main Localizable.strings file. r=ardissone if you promise to make that change in your local copy as soon as you read this ;)
Attachment #244148 - Flags: superreview?(stuart.morgan)
Attachment #244148 - Flags: review?(alqahira)
Attachment #244148 - Flags: review+
Comment on attachment 244149 [details] [diff] [review] String changes Patch looks good; r=ardissone on what may be my only code review ever ;)
Attachment #244149 - Flags: superreview?(stuart.morgan)
Attachment #244149 - Flags: review?(alqahira)
Attachment #244149 - Flags: review+
Comment on attachment 244148 [details] New Strings files sr=me
Attachment #244148 - Flags: superreview?(stuart.morgan) → superreview+
Attachment #244149 - Flags: superreview?(stuart.morgan) → superreview+
Checked in on 1.8branch and trunk.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: