When building SeaMonkey as an XUL app (MOZ_XUL_APP=1) the DOM Inspector option appears in the Tools Menu twice under the mailnews window - first under the Tools itself and then also under the Web Development sub menu. The problem is that Thunderbird have overlaid mailWindowOverlay.xul with their own task overlay: http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/extensions/inspector/jar.mn&mark=8&rev=1.20 That overlay plus SeaMonkey's real overlay means we get the option twice under mailnews. Use of the application attribute within the jar.mn file should solve this problem - I have a patch in work.

This patch specifies the app-ids for the application specific overlays in jar.mn ensuring that they don't interfere with each other. I've tested this on SeaMonkey , suiterunner and Thunderbird trunk custom builds, and Sunbird & Firefox nightly builds and not found any problems.

btw I forgot to say if you're doing a dep build to test this patch, you may need to trash $(objdir)/dist/xpi-stage/inspector/chrome.manifest and then rebuild in $(objdir)/extensions/inspector - the reason being is that it sees the changed app-ids as new lines. I don't think this is a problem for release builds as I believe we normally trash the objdir dir first.

Comment on attachment 229701 [details] [diff] [review] Specify app-ids for app specific overlays. having guids in this file doesn't make me smile, it seems fragile.

Patch checked in. I'd have liked to avoid the guids as well, but as they are app level, the shouldn't change too often.