Closed Bug 35154 Opened 25 years ago Closed 21 years ago

enter_bug.cgi expects UA format some browsers don't deliver (IE)

Categories

(Bugzilla :: Creating/Changing Bugs, defect, P3)

x86
Windows 98

Tracking

()

RESOLVED FIXED
Bugzilla 2.18

People

(Reporter: yflint, Assigned: timeless)

References

Details

(Whiteboard: [metadata:platform,os] enter_bug)

Attachments

(2 files, 1 obsolete file)

Hello, Your page said that i use os =other but i use windows98 thanks
This has nothing to do with the Mozilla Browser (which you selected as the product). Furthermore, in response to your bug, I don't believe Mozilla attempts to determine your OS or platform when you're entering a new bug. I think the default is Other for both and you're expected to choose... In any event, this isn't the place for this. Someone with the appropriate permissions needs to resolve this INVALID.
Changing product to webtools
Component: Browser-General → Bugzilla
Product: Browser → Webtools
Reproduced using both IE and Moz on Windows 98. Confirming as a minor bug. actual expected platform os platform os IE on Win98 other other pc win98 Moz on Win98 PC other pc win98 The user-agents as reported by bugzilla are, respectively, Mozilla/4.0 (compatible; MSIE 5.01; Windows 98) and Mozilla/5.0 (Windows; U; Win98; en-US; m14)
Severity: normal → minor
Status: UNCONFIRMED → NEW
Ever confirmed: true
I thought he was talking about the default value of the combobox for the OS value of a new bug report form? In hindsight, I assume he is referring to the user agent. yflint@hotmail.com, can you elaborate?
tara@tequilarista.org is the new owner of Bugzilla and Bonsai. (For details, see my posting in netscape.public.mozilla.webtools, news://news.mozilla.org/38F5D90D.F40E8C1A%40geocast.com .)
Assignee: terry → tara
This superficially looks like a DUP of bug 16029, "Win 98 not auto recognised.", marked FIXED, but a case was missed there. Checking http://lxr.mozilla.org/mozilla/source/webtools/bugzilla/enter_bug.cgi, line 212, it sure looks like Win98 should be auto-recognized so long as your browser is sending a normal HTTP_USER_AGENT string ... unless this bug refers to a Bugzilla installation that isn't running off the tip. The Win98 line is missing from Bugzilla 2.8. But submissions from IE will not be auto-detected because only Win98 is matched, not Windows.*98. A one-line addition, /Mozilla.*\(Windows.*98/ && do {return "Windows 98";}; would fix that.
Summary: A problem with this page recognizing my operating system → A problem with this page recognizing my operating system (Win98)
Sorry for the spam. New QA Contact for Browser General. Thanks for your help Joseph (good luck with the new job) and welcome aboard Doron Rosenberg
QA Contact: jelwell → doronr
sean - is this fixed?
*** Bug 41837 has been marked as a duplicate of this bug. ***
The core problem here is that the User Agent string provided by IE does not match the pattern used in enter_bug.cgi for determining the operating system. Here's a webserver log entry showing the UA string: 127.0.0.1 - - [07/Jun/2000:15:29:35 -0400] "GET /index.mozilla.html HTTP/1.1" 200 27491 "http://127.0.0.1/" "Mozilla/4.0 (compatible; MSIE 5.0; Windows NT)" which is incompatible with the parsing done by enter_bug.cgi: http://lxr.mozilla.org/mozilla/source/webtools/bugzilla/enter_bug.cgi#193 The matching lines are more strict than they need to be. An example: /Mozilla.*\(WinNT.*\)/ && do {return "Windows NT";}; If this was just (and the others were adjusted likewise) /Win.*NT/ && do (return "Windows NT";); (and the others were adjusted likewise) subtle differences in the way the UA string is formatted would not matter. The same could be said for the block of code at line 134 for pickplatform, but in practice it has been pickos where the problems have shown up. (The same problem was happening for Mozilla builds up until bug 21131 was fixed) enter_bug.cgi doesn't need to enforce a standard UA string format, so it might as well not... with any luck, we'll see more who have up to now preferred IE trying out Mozilla, and filing good bugs, so their OS, and that of anyone else with a browser sending a nonstandard UA string, might as well be recorded properly.
Summary: A problem with this page recognizing my operating system (Win98) → enter_bug.cgi expects UA format some browsers don't deliver (IE)
The relevant standards here are the HTTP 1.0 and 1.1 specs, rfc 1945 & rfc 2068. It looks like the Bugzilla code is enforcing the standard UserAgent string format needlessly strictly. You know, that old principle "Be conservative in that which one produces, and liberal in that which one accepts".
QA Contact: doronr → matty
Target Milestone: --- → Bugzilla 2.14
Non-security issue. Not for you for 2.14. Bad boy. Take for 2.16.
Target Milestone: Bugzilla 2.14 → Bugzilla 2.16
-> Bugzilla product, Creating Bugs component, reassigning.
Assignee: tara → myk
Component: Bugzilla → Creating/Changing Bugs
Product: Webtools → Bugzilla
Version: other → unspecified
Whiteboard: [metadata:platform,os] enter_bug
*** Bug 23583 has been marked as a duplicate of this bug. ***
*** Bug 63871 has been marked as a duplicate of this bug. ***
We are currently trying to wrap up Bugzilla 2.16. We are now close enough to release time that anything that wasn't already ranked at P1 isn't going to make the cut. Thus this is being retargetted at 2.18. If you strongly disagree with this retargetting, please comment, however, be aware that we only have about 2 weeks left to review and test anything at this point, and we intend to devote this time to the remaining bugs that were designated as release blockers.
Target Milestone: Bugzilla 2.16 → Bugzilla 2.18
i own this feature but i don't think this bug is still valid
Assignee: myk → timeless
Keywords: qawanted
Unloved bugs targetted for 2.18 but untouched since 9-15-2003 are being retargeted to 2.20 If you plan to act on one immediately, go ahead and pull it back to 2.18.
Target Milestone: Bugzilla 2.18 → Bugzilla 2.20
Attached patch handle: Windows (95|98|ME) (obsolete) (deleted) — Splinter Review
Input: Mozilla/4.0 (compatible; MSIE 6.0; MSIE 5.5; Windows ME) Oper... Mozilla/4.0 (compatible; MSIE 6.0; Windows 98; Computer) Mozilla/4.0 (compatible; MSIE 5.01; Windows 95)
Attachment #144313 - Flags: review?(kiko)
Comment on attachment 144313 [details] [diff] [review] handle: Windows (95|98|ME) This fixes only the OS field, not the platform. I think it would take one additional line and a rediff from timely to fix that as well (e.g. for WinMe).
Attachment #144313 - Flags: review?(kiko)
Attached patch Test harness (deleted) — Splinter Review
To use export HTTP_USER_AGENT='Mozilla/4.0 (compatible; MSIE 6.0; MSIE 5.5; Windows ME) Oper...' perl -T enter_bug.cgi 2>/dev/null Output is one line: Other other
export HTTP_USER_AGENT='Mozilla/4.0 (compatible; MSIE 6.0; Windows 98; Win 9x 4.90)' perl -T enter_bug.cgi 2> /dev/null PC Windows ME export HTTP_USER_AGENT='Mozilla/4.0 (Windows Me 4.90)' perl -T enter_bug.cgi 2>/dev/null PC Windows ME export HTTP_USER_AGENT='Mozilla/4.0 (compatible; MSIE 6.0; MSIE 5.5; Windows ME) Oper...' perl -T enter_bug.cgi 2>/dev/null PC Windows ME export HTTP_USER_AGENT='Mozilla/1.12 (X11; I; HP-UX A.09.05 9000/715)' perl -T enter_bug.cgi 2>/dev/null HP HP-UX export HTTP_USER_AGENT='Mozilla/2.0 (X11; I; BSD/386 uname failed)' perl -T enter_bug.cgi 2>/dev/null PC BSDI export HTTP_USER_AGENT='WebSage/1.35 (Windows; 95; NT)' perl -T enter_bug.cgi 2>/dev/null PC Windows NT export HTTP_USER_AGENT='Mozilla/1.22 (Compatible; Notes v4.0 Windows-NT Server; InterNotes Navigator/4.0)' perl -T enter_bug.cgi 2>/dev/null PC Windows NT export HTTP_USER_AGENT='Lotus-Notes/4.1 ( Windows-NT Server )' perl -T enter_bug.cgi 2>/dev/null PC Windows NT export HTTP_USER_AGENT='Mozilla/1.22 (Windows; I; 32bit [AXP])' perl -T enter_bug.cgi 2>/dev/null DEC Windows 95 export HTTP_USER_AGENT='WinMosaic/Version 2.0 (ALPHA 2)' perl -T enter_bug.cgi 2>/dev/null PC Windows 95
Attachment #144313 - Attachment is obsolete: true
Attachment #144440 - Flags: review?(vlad)
Attachment #144440 - Flags: review?(vlad) → review+
Flags: blocking2.18?
Flags: approval?
Target Milestone: Bugzilla 2.20 → Bugzilla 2.18
Flags: blocking2.18?
Flags: blocking2.18+
Flags: approval?
Flags: approval+
Checked in by timeless: 03/21/2004 17:48 timeless%mozdev.org mozilla/ webtools/ bugzilla/ enter_bug.cgi 1.89 17/12 Bug 35154 enter_bug.cgi expects UA format some browsers don't deliver (IE) Handle Windows 95/98/Me, Windows-NT, Alpha (AXP), BSD/386, (HP) 9000 Special case winmosaic r=vlad a=justdave
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Keywords: qawanted
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: