Closed Bug 353006 Opened 18 years ago Closed 18 years ago

Disable editing of styles on resource:stylesheets in domi

Categories

(Other Applications :: DOM Inspector, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9alpha

People

(Reporter: jason.barnabe, Assigned: jason.barnabe)

Details

Attachments

(1 file, 2 obsolete files)

Attempts to edit styles on resource: stylesheets fail because of bug 343508. For some reason, this completely borks the domi UI. We should disable editing of styles on resource: stylesheets.
Attached patch patch v1 (obsolete) (deleted) — Splinter Review
Assignee: dom-inspector → jason_barnabe
Status: NEW → ASSIGNED
Attachment #238851 - Flags: superreview?(neil)
Attachment #238851 - Flags: review?(timeless)
I don't like this at all. I see what you're trying to do, and it's acceptable to me in the short term... but I'd request (not require) that a new bug be filed to back this code out once bug 343508 is fixed. I would very much prefer we fix the underlying bug instead. This patch merely wallpapers over the real bug (i.e. makes it harder to reproduce the underlying bug).
(In reply to comment #2) > I'd request (not require) that a new bug be > filed to back this code out once bug 343508 is fixed. That was my intention. (In reply to comment #2) > I would very much prefer we fix the underlying bug instead. Me too, but hacking layout is beyond my abilities. I realized after I left the house that there's no reason to be disabling Copy... New patch coming up.
Attached patch patch v2 (obsolete) (deleted) — Splinter Review
Don't disable Copy.
Attachment #238851 - Attachment is obsolete: true
Attachment #238863 - Flags: superreview?(neil)
Attachment #238863 - Flags: review?(timeless)
Attachment #238851 - Flags: superreview?(neil)
Attachment #238851 - Flags: review?(timeless)
Comment on attachment 238863 [details] [diff] [review] patch v2 >+ rule.parentStyleSheet.href.indexOf("resource:") == 0); Nit: /^resource:/.test(href)
Attachment #238863 - Flags: superreview?(neil) → superreview+
Attached patch patch v3 (deleted) — Splinter Review
Updated to comment.
Attachment #238863 - Attachment is obsolete: true
Attachment #239103 - Flags: superreview+
Attachment #239103 - Flags: review?(timeless)
Attachment #238863 - Flags: review?(timeless)
Attachment #239103 - Flags: review?(timeless) → review+
Whiteboard: [checkin needed]
I've filed bug 354082 to back this out once bug 343508's fixed.
extensions/inspector/resources/content/viewers/styleRules/styleRules.js 1.28
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → mozilla1.9alpha
Actually... the fact that the sheets are resource: sheets has nothing to do with bug 343508. To produce bug 343508 you need two things: 1) An @import rule in a sheet 2) Cloning said sheet This means, for example, any chrome sheet with an @import rule. But there are ways to trigger sheet cloning with web pages -- just have a web page point twice to the same sheet URI (e.g. for different media).
QA Contact: timeless → dom-inspector
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: