Closed
Bug 353006
Opened 18 years ago
Closed 18 years ago
Disable editing of styles on resource:stylesheets in domi
Categories
(Other Applications :: DOM Inspector, defect)
Other Applications
DOM Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9alpha
People
(Reporter: jason.barnabe, Assigned: jason.barnabe)
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
timeless
:
review+
jason.barnabe
:
superreview+
|
Details | Diff | Splinter Review |
Attempts to edit styles on resource: stylesheets fail because of bug 343508. For some reason, this completely borks the domi UI. We should disable editing of styles on resource: stylesheets.
Assignee | ||
Comment 1•18 years ago
|
||
Assignee: dom-inspector → jason_barnabe
Status: NEW → ASSIGNED
Attachment #238851 -
Flags: superreview?(neil)
Attachment #238851 -
Flags: review?(timeless)
Comment 2•18 years ago
|
||
I don't like this at all. I see what you're trying to do, and it's acceptable to me in the short term... but I'd request (not require) that a new bug be filed to back this code out once bug 343508 is fixed.
I would very much prefer we fix the underlying bug instead. This patch merely wallpapers over the real bug (i.e. makes it harder to reproduce the underlying bug).
Assignee | ||
Comment 3•18 years ago
|
||
(In reply to comment #2)
> I'd request (not require) that a new bug be
> filed to back this code out once bug 343508 is fixed.
That was my intention.
(In reply to comment #2)
> I would very much prefer we fix the underlying bug instead.
Me too, but hacking layout is beyond my abilities.
I realized after I left the house that there's no reason to be disabling Copy... New patch coming up.
Assignee | ||
Comment 4•18 years ago
|
||
Don't disable Copy.
Attachment #238851 -
Attachment is obsolete: true
Attachment #238863 -
Flags: superreview?(neil)
Attachment #238863 -
Flags: review?(timeless)
Attachment #238851 -
Flags: superreview?(neil)
Attachment #238851 -
Flags: review?(timeless)
Comment 5•18 years ago
|
||
Comment on attachment 238863 [details] [diff] [review]
patch v2
>+ rule.parentStyleSheet.href.indexOf("resource:") == 0);
Nit: /^resource:/.test(href)
Attachment #238863 -
Flags: superreview?(neil) → superreview+
Assignee | ||
Comment 6•18 years ago
|
||
Updated to comment.
Attachment #238863 -
Attachment is obsolete: true
Attachment #239103 -
Flags: superreview+
Attachment #239103 -
Flags: review?(timeless)
Attachment #238863 -
Flags: review?(timeless)
Attachment #239103 -
Flags: review?(timeless) → review+
Assignee | ||
Updated•18 years ago
|
Whiteboard: [checkin needed]
Assignee | ||
Comment 7•18 years ago
|
||
I've filed bug 354082 to back this out once bug 343508's fixed.
Comment 8•18 years ago
|
||
extensions/inspector/resources/content/viewers/styleRules/styleRules.js 1.28
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → mozilla1.9alpha
Comment 9•18 years ago
|
||
Actually... the fact that the sheets are resource: sheets has nothing to do with bug 343508.
To produce bug 343508 you need two things:
1) An @import rule in a sheet
2) Cloning said sheet
This means, for example, any chrome sheet with an @import rule. But there are ways to trigger sheet cloning with web pages -- just have a web page point twice to the same sheet URI (e.g. for different media).
Updated•17 years ago
|
QA Contact: timeless → dom-inspector
You need to log in
before you can comment on or make changes to this bug.
Description
•