Open Bug 357008 Opened 18 years ago Updated 2 years ago

Remove obsolete directory address books entries from prefs

Categories

(MailNews Core :: Address Book, defect)

defect

Tracking

(Not tracked)

People

(Reporter: standard8, Unassigned)

References

(Blocks 2 open bugs)

Details

(Keywords: helpwanted, perf)

Due to bug 230580 which is now fixed, we created a lot of entries in prefs.js (dependant on usage of Thunderbird & SeaMonkey) as follows: (A) 1st one after Tb 1.5.0.2 user_pref("ldap_2.servers._nonascii.filename", "_nonascii.mab"); user_pref("ldap_2.servers._nonascii.replication.lastChangeNumber", 0); user_pref("ldap_2.servers._nonascii.uri", moz-abldapdirectory://_nonascii.mab"); (B) Additional ones after Tb 1.5.0.2 user_pref("ldap_2.servers._nonascii_x.filename", "_nonascii_x.mab"); user_pref("ldap_2.servers._nonascii_x.replication.lastChangeNumber", 0); user_pref("ldap_2.servers._nonascii_x.uri", "moz-abldapdirectory://_nonascii_1.mab"); (C) When Tb 1.5.0.0/1.5.0.1 and Tb 1.0.x user_pref("ldap_2.servers.user_directory_x.filename", "user_directory_x.mab"); user_pref("ldap_2.servers.user_directory_x.replication.lastChangeNumber", 0); user_pref("ldap_2.servers.user_directory_x.uri", "moz-abldapdirectory://user_directory_x.mab"); Where x is a number > 0. This slowed Thunderbird & SeaMonkey down in various areas (sending emails, autocomplete, address book lookups). Ideally we should be removing those entries now we've stopped the cause. I think this would be possible in the DIR_GetServerPreferences function (http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/addrbook/src/nsDirPrefs.cpp&rev=1.116#195 6 but haven't worked out a way yet, and I'm not going to be able to get around to doing it soon so if anyone can pick this up, that would be really useful.
(In reply to comment #0) > Due to bug 230580 which is now fixed, we created a lot of entries in prefs.js > (dependant on usage of Thunderbird & SeaMonkey) as follows: The creation of "ldap_2.servers._nonascii_#" entries is NOT fixed, at least in the Windows version of Thunderbird 1.5.0.8. which I am currently using -- so it's not clear that the problem described in bug 230580 even relates to this. I found over 5,050 such "_nonascii_#" type entries in my prefs.js file which had started causing extremely long delays to occur when I first attempted to address a message in the composition window after starting TB. While I strongly agree that it would be nice if there was some automatic way of cleaning up all these bogus entries (and perhaps also for any created by bug 230580), I think that the cause of them being added still needs to be first addressed.
Depends on: 378388
Product: Core → MailNews Core
(In reply to Mark Banner (:standard8) from comment #0) > Due to bug 230580 which is now fixed, we created a lot of entries in > prefs.js (dependant on usage of Thunderbird & SeaMonkey) as follows: >... > I think this would be possible in the DIR_GetServerPreferences function > (http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/addrbook/src/ > nsDirPrefs.cpp&rev=1.116#195 6 but haven't worked out a way yet, and I'm not > going to be able to get around to doing it soon so if anyone can pick this > up, that would be really useful. so you will mentor?
Flags: needinfo?(standard8)
Keywords: perf
I'm happy to help out, but I'm not able to confirm I can dedicate enough time for mentoring.
Flags: needinfo?(standard8)
Blocks: 1517958
Summary: Remove obsolete directory entries from address books. → Remove obsolete directory address books entries from prefs

I remember some test cases having a significant performance impact.

Is this obsolete in the post mork era, and if not, is it best done now as part of the migration, or should we defer to some later date?

Flags: needinfo?(geoff)

I'm not adding more to the 68-to-78 migration if that's what you have in mind. That's a risk I'm not willing to take.

Flags: needinfo?(geoff)
Severity: normal → S3
Severity: S3 → S4
You need to log in before you can comment on or make changes to this bug.