Closed Bug 359994 Opened 18 years ago Closed 17 years ago

load Tp2 pageset list dynamically

Categories

(Release Engineering :: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: rhelmer, Assigned: rcampbell)

References

Details

Attachments

(1 file)

It should be possible for Tp2 to load a list of pages to test dynamically, instead of having to hardcode one pageset list into cycler.html
Attached patch load pageset list from file (deleted) — Splinter Review
If the "pageset" HTTP parameter is passed to cycler.html, it will attempt to load the indicated file from the local webserver via XHR and eval it. The intent is to use this file as an override for the "pages" and "pages_i18n" arrays, to specify alternate pagesets to use.
Assignee: nobody → rhelmer
Status: NEW → ASSIGNED
Attachment #245022 - Flags: review?
Attachment #245022 - Flags: review? → review?(vladimir)
Comment on attachment 245022 [details] [diff] [review]
load pageset list from file

I think this will fail with file:// URIs, but as the pageset is served from a local server, it should be good enough for now to fix the immediate problem.
Attachment #245022 - Flags: review?(vladimir) → review+
(In reply to comment #2)
> (From update of attachment 245022 [details] [diff] [review] [edit])
> I think this will fail with file:// URIs, but as the pageset is served from a
> local server, it should be good enough for now to fix the immediate problem.

Just tested, as long as the test was loaded with file:// then this should work for that case as well.

Alice, would this patch be useful to you? I'll go ahead and land if so. This lets you specify the file to load URLs from instead of hardcoding into the test itself (it can be overridden by hardcoding, so it should still be backwards compatible).
Status: ASSIGNED → NEW
Severity: normal → enhancement
Status: NEW → ASSIGNED
Assignee: rhelmer → rcampbell
Status: ASSIGNED → NEW
Blocks: 386081
This is no longer needed as we've gone over to using the pageloader with loads urls from a given file - so they are no longer hard coded into the cycling code.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → WONTFIX
Component: Testing → Release Engineering: Talos
Product: Core → mozilla.org
QA Contact: testing → release
Version: Trunk → other
Component: Release Engineering: Talos → Release Engineering
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: