User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.7) Gecko/20060910 SeaMonkey/1.0.5 Mnenhy/0.7.4.0 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.7) Gecko/20060910 SeaMonkey/1.0.5 Mnenhy/0.7.4.0 The Mozilla build system for building Thunderbird (trunk) does not honor this ./configure option: --disable-printing . The make fails with this output: > nsMessenger.cpp:86:32: nsIWebBrowserPrint.h: No such file or directory > In file included from nsMessenger.cpp:133: > nsMsgPrintEngine.h:53:32: nsIWebBrowserPrint.h: No such file or directory > nsMsgPrintEngine.h:60:30: nsIPrintProgress.h: No such file or directory > nsMsgPrintEngine.h:61:36: nsIPrintProgressParams.h: No such file or directory > nsMsgPrintEngine.h:62:38: nsIPrintingPromptService.h: No such file or directory Most probably there are many other places in the code where the --disable-priting option isn't recognized also. Reproducible: Always Steps to Reproduce: 1. Install Thunderbird trunk from CVS. 2. Configure it with the --disable-printing option to ./configure 3. Compile Thunderbird using "make" (GNU make). Actual Results: nsMessenger.cpp:86:32: nsIWebBrowserPrint.h: No such file or directory In file included from nsMessenger.cpp:133: nsMsgPrintEngine.h:53:32: nsIWebBrowserPrint.h: No such file or directory nsMsgPrintEngine.h:60:30: nsIPrintProgress.h: No such file or directory nsMsgPrintEngine.h:61:36: nsIPrintProgressParams.h: No such file or directory nsMsgPrintEngine.h:62:38: nsIPrintingPromptService.h: No such file or directory In file included from nsMessenger.cpp:133: nsMsgPrintEngine.h:119: error: `nsIPrintingPromptService' was not declared in this scope nsMsgPrintEngine.h:119: error: template argument 1 is invalid nsMsgPrintEngine.h:119: error: ISO C++ forbids declaration of ` mPrintPromptService' with no type nsMsgPrintEngine.h:121: error: `nsIPrintProgress' was not declared in this scope nsMsgPrintEngine.h:121: error: template argument 1 is invalid nsMsgPrintEngine.h:121: error: ISO C++ forbids declaration of `mPrintProgress' with no type nsMsgPrintEngine.h:122: error: `nsIPrintProgressParams' was not declared in this scope nsMsgPrintEngine.h:122: error: template argument 1 is invalid nsMsgPrintEngine.h:122: error: ISO C++ forbids declaration of ` mPrintProgressParams' with no type Expected Results: I expected Thunderbird to be built without printing support.

let's just drop --disable-printing

If you're ok with that from a small-device embedding perspective, I'm all for it!

Supporting --disable-printing would allow people to remove a significant amount of bulk from their builds of Thunderbird. And naturally, in a "small-device embedded" environment, the printing code is a gratuitous waste of space. The --disable-printing option is a good idea.

as noted in previous comments, this helps for mobile where we're missing certain headers

Comment on attachment 312388 [details] [diff] [review] respects the --disable-printing flag for gtk2 I need this to be a unified diff... it's really hard to see what has changed here.

Brad: you need to set the review flag like before.

Brad: anything happening with this? Was the reviewed patch checked in? IMHO this looks like it should be a core/build config bug now as its obviously not just Thunderbird that's affected.

I verify that the situation is similar when building firefox 3. Even when I build with --disable printing, the gtk+-unix-print-2.0 headers and libraries are still needed and the build fails because they are not available in my system. Perhaps this bug should also refer to firefox, not only thunderbird?

Comment on attachment 313083 [details] [diff] [review] unified version of patch [Checkin: Comment 10] http://hg.mozilla.org/mozilla-central/index.cgi/log?rev=9ec74af08980

On my Windows 2000, Firefox 3.1a2pre builds fine. But SeaMonkey v2.0a1pre does not: {{ .../mailnews/base/src/nsMessenger.cpp(83) : fatal error C1083: Cannot open include file: 'nsIWebBrowserPrint.h': No such file or directory }} *** Brad, could you port your GTK2 patch to the other platforms ?

This is still very much a problem in tb-3.1.1. nsMessenger.cpp:82:32: fatal error: nsIWebBrowserPrint.h: No such file or directory compilation terminated.

This is just a start, there is much more that will needed to be completed before we will have a working build.

This has been fully tested with both --disable-printing and --enable-printing. I have been unable to find any regressions using it.

I think attachment 462613 [details] [diff] [review] should be the same as this patch here, if not, it would be nice to integrate the very few differences and get all this resolved at once, as the duping suggests.

Robert if you could double check to ensure that I did not overlook any of your changes as well would be appreciated.

Comment on attachment 467248 [details] [diff] [review] intergrate all changes that Robert had made as well. r=Standard8 Note: If you want this to get into 1.9.2 then we'll need a 1.9.2 version of this patch - I think the one you obsoleted would actually do most of that.

Checked in: http://hg.mozilla.org/comm-central/rev/0eb496737b06

(In reply to comment #21) > Comment on attachment 467248 [details] [diff] [review] > intergrate all changes that Robert had made as well. > > r=Standard8 > > Note: If you want this to get into 1.9.2 then we'll need a 1.9.2 version of > this patch - I think the one you obsoleted would actually do most of that. I actually have the comm-1.9.2 branch patch, just need to recheck the work before I post it for you, I actually did miss a few sections that needed to be ifdef'd.

Mark hope you can get this landed before next release.

Reopening until we get it fixed on comm-1.9.2

Sorry included in patch was the revert of another bug. Which I will post to the correct bug.

(In reply to comment #25) > Reopening until we get it fixed on comm-1.9.2 Jory: Our standard practice is to mark fixed once a bug is fixed on trunk. Branches are controlled by flags, see here for more info: https://wiki.mozilla.org/Thunderbird/Landing_Patches_on_Thunderbird3.1

Checked into 1.9.2 branch: http://hg.mozilla.org/releases/comm-1.9.2/rev/07af9eb570c3