Robert Kaiser Assignee
	Description • 16 years ago

For fun, I have a SeaMonkey cairo-qt build tree around, and after bug 480689 has been fixed now, the platform compiles fine, but then I'm running into this error:

gmake[5]: Entering directory `/mnt/mozilla/build/seamonkey-qt/mailnews/base/src'
nsMessenger.cpp
c++ -o nsMessenger.o -c -I../../../mozilla/dist/include/system_wrappers -include /mnt/mozilla/hg/comm-central-trunk/mozilla/config/gcc_hidden.h -DMOZ_LDAP_XPCOM -DMOZILLA_INTERNAL_API -DMOZ_SUITE=1 -DSUITE_USING_XPFE_DM=1 -DOSTYPE=\"Linux2.6\" -DOSARCH=Linux -DHAVE_MOVEMAIL  -I/mnt/mozilla/hg/comm-central-trunk/mailnews/base/src -I. -I../../../mozilla/dist/include/xpcom -I../../../mozilla/dist/include/alerts -I../../../mozilla/dist/include/string -I../../../mozilla/dist/include/necko -I../../../mozilla/dist/include/dom -I../../../mozilla/dist/include/appshell -I../../../mozilla/dist/include/toolkitcomps -I../../../mozilla/dist/include/appcomps -I../../../mozilla/dist/include/uconv -I../../../mozilla/dist/include/intl -I../../../mozilla/dist/include/htmlparser -I../../../mozilla/dist/include/widget -I../../../mozilla/dist/include/docshell -I../../../mozilla/dist/include/rdf -I../../../mozilla/dist/include/gfx -I../../../mozilla/dist/include/thebes -I../../../mozilla/dist/include/layout -I../../../mozilla/dist/include/content -I../../../mozilla/dist/include/mailnews -I../../../mozilla/dist/include/locale -I../../../mozilla/dist/include/unicharutil -I../../../mozilla/dist/include/msgbaseutil -I../../../mozilla/dist/include/webshell -I../../../mozilla/dist/include/txmgr -I../../../mozilla/dist/include/msgcompose -I../../../mozilla/dist/include/msgdb -I../../../mozilla/dist/include/uriloader -I../../../mozilla/dist/include/pref -I../../../mozilla/dist/include/msglocal -I../../../mozilla/dist/include/msgimap -I../../../mozilla/dist/include/mork -I../../../mozilla/dist/include/msgnews -I../../../mozilla/dist/include/addrbook -I../../../mozilla/dist/include/mime -I../../../mozilla/dist/include/mimetype -I../../../mozilla/dist/include/windowwatcher -I../../../mozilla/dist/include/webbrwsr -I../../../mozilla/dist/include/exthandler -I../../../mozilla/dist/include/xulapp -I../../../mozilla/dist/include/caps -I../../../mozilla/dist/include/xpconnect -I../../../mozilla/dist/include/js -I../../../mozilla/dist/include/mozldap -I../../../mozilla/dist/include   -I../../../mozilla/dist/include/msgbase `../../../mozilla/nsprpub/config/nspr-config --prefix=../../../mozilla/dist --includedir=../../../mozilla/dist/include/nspr --cflags`        -fPIC   -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-long-long -pedantic -march=pentium4 -mtune=nocona -msse2 -msse3 -mssse3 -mfpmath=sse -fno-strict-aliasing -fshort-wchar -pthread -pipe  -DNDEBUG -DTRIMMED -Os -freorder-blocks -fno-reorder-functions    -DMOZILLA_CLIENT -include ../../../mozilla-config.h -Wp,-MD,.deps/nsMessenger.pp /mnt/mozilla/hg/comm-central-trunk/mailnews/base/src/nsMessenger.cpp
/mnt/mozilla/hg/comm-central-trunk/mailnews/base/src/nsMessenger.cpp:82:32: error: nsIWebBrowserPrint.h: No such file or directory
In file included from /mnt/mozilla/hg/comm-central-trunk/mailnews/base/src/nsMessenger.cpp:128:
/mnt/mozilla/hg/comm-central-trunk/mailnews/base/src/nsMsgPrintEngine.h:60:30: error: nsIPrintProgress.h: No such file or directory
/mnt/mozilla/hg/comm-central-trunk/mailnews/base/src/nsMsgPrintEngine.h:61:36: error: nsIPrintProgressParams.h: No such file or directory
/mnt/mozilla/hg/comm-central-trunk/mailnews/base/src/nsMsgPrintEngine.h:62:38: error: nsIPrintingPromptService.h: No such file or directory
In file included from /mnt/mozilla/hg/comm-central-trunk/mailnews/base/src/nsMessenger.cpp:128:
/mnt/mozilla/hg/comm-central-trunk/mailnews/base/src/nsMsgPrintEngine.h:119: error: 'nsIPrintingPromptService' was not declared in this scope
/mnt/mozilla/hg/comm-central-trunk/mailnews/base/src/nsMsgPrintEngine.h:119: error: template argument 1 is invalid
/mnt/mozilla/hg/comm-central-trunk/mailnews/base/src/nsMsgPrintEngine.h:121: error: 'nsIPrintProgress' was not declared in this scope
/mnt/mozilla/hg/comm-central-trunk/mailnews/base/src/nsMsgPrintEngine.h:121: error: template argument 1 is invalid
/mnt/mozilla/hg/comm-central-trunk/mailnews/base/src/nsMsgPrintEngine.h:122: error: 'nsIPrintProgressParams' was not declared in this scope
/mnt/mozilla/hg/comm-central-trunk/mailnews/base/src/nsMsgPrintEngine.h:122: error: template argument 1 is invalid
/mnt/mozilla/hg/comm-central-trunk/mailnews/base/src/nsMessenger.cpp: In function 'int CompareAttachmentPartId(const char*, const char*)':
/mnt/mozilla/hg/comm-central-trunk/mailnews/base/src/nsMessenger.cpp:2143: warning: deprecated conversion from string constant to 'char*'
/mnt/mozilla/hg/comm-central-trunk/mailnews/base/src/nsMessenger.cpp:2146: warning: deprecated conversion from string constant to 'char*'
gmake[5]: *** [nsMessenger.o] Error 1
gmake[5]: Leaving directory `/mnt/mozilla/build/seamonkey-qt/mailnews/base/src'
gmake[4]: *** [src_libs] Error 2
gmake[4]: Leaving directory `/mnt/mozilla/build/seamonkey-qt/mailnews/base'
gmake[3]: *** [libs_tier_app] Error 2
gmake[3]: Leaving directory `/mnt/mozilla/build/seamonkey-qt'
gmake[2]: *** [tier_app] Error 2
gmake[2]: Leaving directory `/mnt/mozilla/build/seamonkey-qt'
gmake[1]: *** [default] Error 2
gmake[1]: Leaving directory `/mnt/mozilla/build/seamonkey-qt'
gmake: *** [build] Error 2


This is with Qt 4.5.0-rc1 and a comm-central/mozilla-central tree from today.
We might not have native printing support in Qt right now, maybe this is connected to that in some way.
I know that cairo-qt isn't really a supported config, but it would be nice if it would compile for experiments like this ;-)

	Robert Kaiser Assignee
	Comment 1 • 16 years ago

The problem is that printing support with Qt doesn't work, that's right, but even with unsetting NS_PRINTING (or --disable-printing), which is what mozilla-central is doing, mailnews fails to compile, as it thinks this is always enabled.

	Robert Kaiser Assignee
	Comment 2 • 15 years ago

This patch at least makes us compile on trunk, though it currently just happens to work because NS_PRINTING is always unset as we never actually do set it any more...

	Serge Gautherie (:sgautherie)
	Comment 3 • 15 years ago

(In reply to comment #1)
> even with unsetting NS_PRINTING (or --disable-printing)

I removed this variable in bug 513709 because I understood it didn't make a difference here :-<

(In reply to comment #2)
> This patch at least makes us compile on trunk

I restored the variable in bug 544913 to support this (too) ;->

	Robert Kaiser Assignee
	Comment 4 • 14 years ago

This patch respects --disable-printing, which is what Qt needs for the moment.

	Jory A. Pratt [:anarchy]
	Comment 6 • 14 years ago

(In reply to comment #4)
> Created attachment 462613 [details] [diff] [review]
> v1: respect --disable-printing
> 
> This patch respects --disable-printing, which is what Qt needs for the moment.

Robert I was meaning to ask you to attach your patch to bug #362455, make sure you describe that it applies to comm-central and not comm-1.9.2 please. Assign review to bugzilla@standard8.plus.com instead of dmos.

	Robert Kaiser Assignee
	Comment 7 • 14 years ago

Do it yourself if you like it your way, I have enough really important stuff to tend to that I don't need to play stupid games.

	Dan Mosedale (:dmosedale, :dmose)
	Comment 8 • 14 years ago

Robert, while it's entirely reasonable to decline a request that someone else makes of you, in the future, please do so respectfully.  I'll try and get to reviewing this on Friday.

	Dan Mosedale (:dmosedale, :dmose)
	Comment 9 • 14 years ago

Although, looking at the duplicated bug, since Mark has taken the review of that one, I think it probably doesn't make sense for different people to review these bugs.  Reassigning review.

	Robert Kaiser Assignee
	Comment 10 • 14 years ago

(In reply to comment #8)
> Robert, while it's entirely reasonable to decline a request that someone else
> makes of you, in the future, please do so respectfully.

Sorry, I thought he had removed the review. It doesn't make sense to have the same things up for review twice, and he obviously just trampled on the work I did here, so I was a bit outraged, but I care too little about this bug to care too much, and that's what I wanted to say. I'm annoyed enough about important things not moving forward (not your fault) that I just think moving around those small unimportant things just because someone cares about whatever and not Qt builds is ridiculous to say the least.

	Robert Kaiser Assignee
	Comment 11 • 14 years ago

Comment on attachment 462613 [details] [diff] [review]
v1: respect --disable-printing

reviews on a resolved bug, even more a dupe, are stupid, so let's remove this.

	Jory A. Pratt [:anarchy]
	Comment 12 • 14 years ago

(In reply to comment #10)
> (In reply to comment #8)
> > Robert, while it's entirely reasonable to decline a request that someone else
> > makes of you, in the future, please do so respectfully.
> 
> Sorry, I thought he had removed the review. It doesn't make sense to have the
> same things up for review twice, and he obviously just trampled on the work I
> did here, so I was a bit outraged, but I care too little about this bug to care
> too much, and that's what I wanted to say. I'm annoyed enough about important
> things not moving forward (not your fault) that I just think moving around
> those small unimportant things just because someone cares about whatever and
> not Qt builds is ridiculous to say the least.

Robert I never said I did not care about your bug in QT, but this is not just a bug in QT we are talking about every build that someone might use with --disable-printing. If you feel I trampled your work I apoligize that was not the intentsions by any means. What I am concerned with is proper builds that are currently supported and need to be resolved in a timely manner. That said please leave your patch up for review all you had to due was reopen the bug report.

	Robert Kaiser Assignee
	Comment 13 • 14 years ago

Comment on attachment 462613 [details] [diff] [review]
v1: respect --disable-printing

Fore one thing, sorry for overreacting, my frustration over things not progressing in some areas is burning me out recent and leading to being overly harsh at times. Sorry.

For the other, there's no need for Mark to review two patches that are doing the same, and the other one is on an open bug, so this one is redundant and should go away.