Closed
Bug 368279
Opened 18 years ago
Closed 18 years ago
don't blindly copy the uninstall.log to temp, and don't call \uninstalllog=<path> if we don't modify the log
Categories
(Toolkit :: Application Update, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 354226
People
(Reporter: moco, Assigned: moco)
References
Details
don't blindly copy the uninstall.log to temp, and don't call \uninstalllog=<path> if we don't modify the log
this is a spin off from bug #354226
we currently always copy the log file to a unique dir under tmp, and then call app.postUpdate(copiedLog);
we should keep track, in nsPostUpdateWin.js if we actually write any new lines to the copiedLog here:
for (var relPath in newEntries)
this._writeLine(PREFIX_FILE + relPath);
if not, we should remove the unique dir (and the copied log), and call app.postUpdate(nsnull).
we'll need to fix this code:
NS_IMETHODIMP
nsXULAppInfo::PostUpdate(nsILocalFile *aLogFile)
{
// XXX todo
// if aLogFile is null, don't fail.
// just call with out that arg
NS_ENSURE_ARG_POINTER(aLogFile);
to allow for a null log file, and then pass one less arg.
rob already has changes to make this an optional param in the uninstaller (I think, I'll double check with him.)
Assignee | ||
Comment 1•18 years ago
|
||
this fix for this is included in the patch for bug #354226
Assignee | ||
Comment 2•18 years ago
|
||
part of the fix for bug #354226, so marking a dup.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → DUPLICATE
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•