Closed
Bug 369767
Opened 18 years ago
Closed 18 years ago
"About" and "Preferences" menuitems doesn't work when running Venkman
Categories
(Core :: Widget: Cocoa, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: stefanh, Assigned: jaas)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
(deleted),
patch
|
stuart.morgan+bugzilla
:
review+
mikepinkerton
:
superreview+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
Minefield trunk debug, source about 4-5 days old, 10.3.9 (ppc build with 10.3.0 sdk)
STR:
1) Open Minefield
2) Launch Venkman
3) Once Venkman has opened, do "Minefield" --> "About Minefield"
Results: Nothing happens.
4) Switch focus to Minefield and do "Minefield" --> "About Minefield"
Results: Nothing happens.
5) Now, switch focus to Venkman and try to open Preferences from the Minefield menu (or shortcut)
Results: No pref window opens and the Console window spits out an assertion:
###!!! ASSERTION: Carbon event for menu hit not sent!: 'err == noErr', file /Users/Stefan/debug/mozilla/widget/src/cocoa/nsMenuBarX.mm, line 1115
If you switch focus to Minefield you can open the pref window (but I get another, probably known, assertion 3 times).
I haven't checked, but I'm pretty sure this is old (from the cocoa-switch)
Updated•18 years ago
|
Flags: blocking1.9?
"Preferences" is fixed in Venkman now because of the fix for bug 368911. I'm looking into the "About Minefield" part.
This fixes it, we just need to do the same thing with content nodes for the "About" menu item that we do for prefs and quit. We should have done this a long time ago.
Attachment #259741 -
Flags: review?(mano)
Reporter | ||
Comment 3•18 years ago
|
||
Nice, this also hides it :-)
Updated•18 years ago
|
Attachment #259741 -
Flags: review?(mano) → review+
Attachment #259741 -
Flags: superreview?(roc)
Flags: blocking1.9? → blocking1.9+
Comment 4•18 years ago
|
||
Comment on attachment 259741 [details] [diff] [review]
fix v1.0
rs=pink
Attachment #259741 -
Flags: superreview?(roc) → superreview+
fixed on trunk
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Attachment #259854 -
Flags: review?(mano)
Attachment #259855 -
Flags: review?(mano)
Comment 8•18 years ago
|
||
Comment on attachment 259854 [details] [diff] [review]
followup separator fix, v1.0
r=mano.
Attachment #259854 -
Flags: review?(mano) → review+
Comment 9•18 years ago
|
||
Comment on attachment 259855 [details] [diff] [review]
remove browser workarounds, v1.0
r=mano, thanks.
Attachment #259855 -
Flags: review?(mano) → review+
Assignee | ||
Comment 10•18 years ago
|
||
followup separator fix and remove browser workarounds checked in on trunk
Comment 11•18 years ago
|
||
Because of the last check-in the 'Report Web Forgery' menu item has moved on Windows. It is now grouped with the check for updates menu item because it inserts itself before the menu separator with id = aboutSeparator.
You need to log in
before you can comment on or make changes to this bug.
Description
•