From Bugzilla Helper: User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:0.9.8+) Gecko/20020225 BuildID: 2002022508 Since Mozilla is now using the application ("Mozilla") menu on OS X correctly (yay!), it should probably use the Help menu correctly. According to the Aqua HIG, the help menuitem should be called "Mozilla Help". And "About Mozilla" shouldn't appear here still. (Not sure about "About Plugins", but putting it in the Mozilla menu below "About Mozilla" would make sense to me.) Reproducible: Always Steps to Reproduce: 1. Start up Mozilla on OS X Actual Results: Help menu has "About Mozilla", etc. Expected Results: Help menu should look like other Mac OS X help menus. There is a precedent: Preferences was removed from the Edit menu after it was added to the Mozilla menu.

Confirming this - can't find any dupes. Making this a dependency of bug 73812 - the general "confirm to MacOS X HIG" meta bug. Also just to emphasise its the "menuitem" that says "Mozilla Help" - not the menu! (I had to read the original report a couple of times to spot this). It shouldn't be too difficult - when I looked at the code for the Preference menu moving to "Mozilla" from "Edit" there was some sort of "Aquify" flag and we just added the menu to a different parent object if it was set.

Infact there's a method AquifyMenuBar() at http://lxr.mozilla.org/seamonkey/source/widget/src/mac/nsMenuBarX.cpp#255 Guess it doesn't quite do enough work just yet :)

uid is being phased out.

-> XP Apps (we have bug(s) for ff and tb)

In order to make the help menu conform better with Apple HIG, we should: 1) Remove the "About Mozilla" menuitem 2) Change the "Help Contents" menuitem to "&brandShortname; Help" 3) Remove the "For Internet Explorers" menuitem I'll leave the About Plug-ins menuitem as it is.

Comment on attachment 183605 [details] [diff] [review] Help menu fix Forgot to mention that this is only tested on mac. It also appears that helpMenuOverlay.dtd (in respitory) lacks an eof.

Comment on attachment 183605 [details] [diff] [review] Help menu fix IMHO: * Any menuitems that should be hidden (and I only agree with About Mozilla) go in AquifyMenuBar() * Help should use platformCommunicatorOverlay.dtd to get its Help Contents label * Accesskeys should be specified in the same case as they appear in the label Please also try to line up the entity values.

New version addressing Neils comments 2) and 3). Fixed some tabbing issues as well. Note: This version doesn't hide any menuitems. Those will be fixed by the separate bug(s).

(In reply to comment #8) >Please also try to line up the entity values. Actually I only meant the new ones unless you want blame for the whole file ;-)

Comment on attachment 183818 [details] [diff] [review] New version >>+<!ENTITY % platformCommunicationDTD SYSTEM "chrome://communicator-platform/locale/platformCommunicatorOverlay.dtd"> >+%platformCommunicationDTD; > ]> nit: use platformCommunicatorDTD please (not "Communication") >+<!ENTITY openHelpCmd.accesskey "H"> Never seperate the accesskey from the string. People might want/need to localize it differently according to what their platform-specific translation of the entry is. Please move it over to platformCommunicatorOverlay.dtd as well.

OK, here's another version. * Moves openHelpCmd.accesskey to platformCommunicatorOverlay.dtd's * Lines up just the entities I've added, except for one ;) * Fixes the dtd spelling error in both helpMenuOverlay.xul and the platformCommunicatorOverlay.xul files

Comment on attachment 183841 [details] [diff] [review] Another version This one looks good, yes. r=me

Comment on attachment 183841 [details] [diff] [review] Another version >-<!ENTITY helpForIEUsers.label "For Internet Explorer Users"> >-<!ENTITY helpForIEUsers.accesskey "i"> >+<!ENTITY helpForIEUsers.label "For Internet Explorer Users"> >+<!ENTITY helpForIEUsers.accesskey "I"> Nit: you could kill one space before the text, that would then mean that the first line of the above is unchanged.

Comment on attachment 183841 [details] [diff] [review] Another version r=mano, fwiw.

Requesting approval, low-risk patch...

Comment on attachment 183865 [details] [diff] [review] Addressing Neil's nit and carrying over flags (Checked in) a=asa for seamonkey only change.

Comment on attachment 183865 [details] [diff] [review] Addressing Neil's nit and carrying over flags (Checked in) Checking in extensions/help/resources/content/helpMenuOverlay.xul; new revision: 1.13; previous revision: 1.12 Checking in extensions/help/resources/locale/en-US/helpMenuOverlay.dtd; new revision: 1.4; previous revision: 1.3 Checking in xpfe/communicator/resources/content/mac/platformCommunicatorOverlay.xul; new revision: 1.11; previous revision: 1.10 Checking in xpfe/communicator/resources/content/unix/platformCommunicatorOverlay.xul; new revision: 1.5; previous revision: 1.4 Checking in xpfe/communicator/resources/content/win/platformCommunicatorOverlay.xul; new revision: 1.5; previous revision: 1.4 Checking in xpfe/communicator/resources/locale/en-US/mac/platformCommunicatorOverlay.dtd; new revision: 1.6; previous revision: 1.5 Checking in xpfe/communicator/resources/locale/en-US/unix/platformCommunicatorOverlay.dtd; new revision: 1.4; previous revision: 1.3 Checking in xpfe/communicator/resources/locale/en-US/win/platformCommunicatorOverlay.dtd; new revision: 1.4; previous revision: 1.3 done

I'll keep this open until the "about" issue is resolved.

The checkin of this bug causes the undefined entity openHelpCmd.label for Thunderbird. This is covered in bug 298618.

Neil, can we get rid of the "About SeaMonkey" item for just the 1.8 branch? And then wait for the core fix for 1.1? I doubt that the core issue will be fixed in time (it hasn't in 2 years) and it would be nice to show some mac ui improvement :)

Hide the menuitem for mac users.

Comment on attachment 194355 [details] [diff] [review] Hide "About SeaMonkey" [checked in on 1.8 branch only] Is this just for the branch, or is this for trunk too until Mac widget guys sort out a generic solution?

Comment on attachment 194355 [details] [diff] [review] Hide "About SeaMonkey" [checked in on 1.8 branch only] r=mano. We're planing to do something useful with the mac application menu in the 1.9 timeframe, so please don't land this on the trunk.

Comment on attachment 194355 [details] [diff] [review] Hide "About SeaMonkey" [checked in on 1.8 branch only] Asking approval for a SeaMonkey mac ui improvement (safe).

Asaf, will there be more changes to the app menu or is the current status the final? Just curious, since if it is the final I need to hide the about menuitem on trunk as well.

Josh has a fix in bug 369767 that will fix the "About" menuitem :-)

Josh fixed the last remaining issue ("About" menuitem in Help menu). Resolving as fixed.