HTTP auth dialogs don't come up at all in my build, after the password manager landing yesterday. There seem to be two problems here: 1) we no longer decode the old-format passwords 2) HTTP auth dialogs don't come up when password manager fails I'll attach a patch for (1). I've tested that the decoding is correct using dump(), although I haven't gotten the passwords to do anything useful for me.

Comment on attachment 265074 [details] [diff] [review] patch to decode the old-format passwords s/pre-Mozilla-1.0/older/, since apparently that's not quite the case. Looks like wallet can still create entries like this, for people using SeaMonkey.

Should add a test in http://lxr.mozilla.org/seamonkey/source/toolkit/components/passwordmgr/test/unit/

Should also still fix part (2); I don't have time for either right now.

(In reply to comment #3) > Should also still fix part (2); I don't have time for either right now. > I'm sorry if I implied that any of these issues were your duty to fix. I don't have time for them either. :)

Uh-oh, why is everyone looking at me?! :-)

Uh-oh, why is everyone looking at me?! :-)

Comment on attachment 265074 [details] [diff] [review] patch to decode the old-format passwords >+ // The pre-Mozilla-1.0 file format obscured entries by pre-Firefox-1.0, right?

Test cases to make sure we can handle this format.

(In reply to comment #8) > Created an attachment (id=265472) [details] > Testcase for mime64 encoded passwords Oh, these depend on some changes made in attachment 265468 [details] [diff] [review] for bug 380931. That'll need checked in first... (In reply to comment #7) > pre-Firefox-1.0, right? The comment now just reads "The older file format obscured entries [...]". Since SeaMonkey can still be using this format, it doesn't really matter exactly when Firefox switched.

Comment on attachment 265472 [details] [diff] [review] Testcase for mime64 encoded passwords >Index: toolkit/components/passwordmgr/test/unit/test_storage_legacy_3.js >+/* >+ * Test suite for storage-Legacy.js -- various bug fixes. let's list bugs here, its probably going to be useful someday. Otherwise, r=me

(In reply to comment #10) > let's list bugs here, its probably going to be useful someday. Already fixed in changes for a different bug, so no need to respin these diffs.

Fixed a nsIFile usage, found when changing test case in bug 380931.

Oops, the last "Updated testcase" included some extra test code not meant for this bug.

Updating summary to reflect the major issue addressed here. I've spun off the other issue (no auth prompt when login manager fails to bug 382180).

(patch and testcase have been checked in)