Spinoff from bug 380961... storage-Legacy.js was throwing because it didn't like an item in signons2.txt. While a failure in the login manager is obviously likely to not fill in an existing password, the code should ideally be fail-safe enough so that you at least get an authentication prompt you can fill out manually.

moving out, needs to make b1...

This basically wraps up the promptAuth() code in try/catch blocks. I used dump() to report an error instead of this.log() juuuuust in case it's the logging causing a problem. Maybe that's too paranoid? I'll also attach a version of this patch that ignores whitespace, since the indenting from the |try {}| wrappers isn't really changing code.

Comment on attachment 284360 [details] [diff] [review] Patch for review, v.1 I'm a bit nervous about adding try/catch blocks around large amounts of code because similar approaches to robustness have caused hard-to-find and hard-to-debug-remotely problems in the past, but I suppose this is OK as long as the failure cases aren't something we'd miss in testing, which appears to be the case here, and the error reporting for any exceptions is solid. I think you should use Components.utils.reportError() instead or in addition to the dump()s in the catch() blocks, though. r=me with that.

Oops, left a file out from v.2.

Checking in toolkit/components/passwordmgr/src/nsLoginManagerPrompter.js; /cvsroot/mozilla/toolkit/components/passwordmgr/src/nsLoginManagerPrompter.js,v <-- nsLoginManagerPrompter.js new revision: 1.12; previous revision: 1.11 done Checking in embedding/components/windowwatcher/src/nsPrompt.cpp; /cvsroot/mozilla/embedding/components/windowwatcher/src/nsPrompt.cpp,v <-- nsPrompt.cpp new revision: 1.32; previous revision: 1.31

This appears to have broken embedders using nsIAuthPrompt; see bug 403115 for details.