Closed Bug 385614 Opened 17 years ago Closed 17 years ago

Assert like mad when deleting Livemarks from left pane in the BM

Categories

(Firefox :: Bookmarks & History, defect, P1)

x86
Windows Vista
defect

Tracking

()

VERIFIED FIXED
Firefox 3 alpha6

People

(Reporter: stephend, Assigned: asaf)

References

Details

Attachments

(1 file)

Build ID: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a6pre) Gecko/20070623 Minefield/3.0a6pre (this has been happening for a while now; I just not got the guts/inclination to file). A bit of history: This is the same profile that I and Seth used to file/fix bug 384731 and bug 384733. See https://bugzilla.mozilla.org/show_bug.cgi?id=384731#c9 and https://bugzilla.mozilla.org/show_bug.cgi?id=384731#c12 for what worries mano and seth, "a places.sqlite file with a bookmarkPropertiesDialog/lastUsed annotation for item_id of 0" Summary: Assert like mad when deleting Livemarks from left pane in the BM of a screwed-up profile Steps to Reproduce: 1. In my screwed-up profile, which is too big to attach here (so I'll send it via AIM or IRC/DCC to whomever might take this), open the Bookmarks Manager via "Organize Bookmarks" 2. Under the "Bookmarks" root tree folder, select the Livemarks (source doesn't matter) and choose Delete Actual Results: Assert like mad, then they're deleted Expected Results: Just delete them
Not a screwed up profile issue... Basically the code in getInsertionPoint isn't aware of the showRoot mode, in which the selected-item might not have a parent node.
Assignee: nobody → mano
Priority: -- → P1
Summary: Assert like mad when deleting Livemarks from left pane in the BM of a screwed-up profile → Assert like mad when deleting Livemarks from left pane in the BM
Target Milestone: --- → Firefox 3 alpha6
Attached patch patch (deleted) — Splinter Review
Attachment #269604 - Flags: review?(dietrich)
Status: NEW → ASSIGNED
Attachment #269604 - Flags: review?(dietrich) → review+
mozilla/browser/components/places/content/tree.xml 1.76
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Using the steps to reproduce in comment 0, I can no longer reproduce any assertions on deletion with build Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a6pre) Gecko/2007062421 Minefield/3.0a6pre. Verified FIXED
Status: RESOLVED → VERIFIED
double verfied. another way to have hit this bug was: 1) with a profile, set the top level "Bookmarks" folder as the personal toolbar folder 2) delete all the sub folders, so all you have is the top level "Bookmarks" folder. when you deleted the last folder, you would have asserted "like mad" during command updating. After mano's fix, I no longer asserting here. Note, with the history sidebar, I think there was another assertion lurking when in sort by day or day / site that this patch will also prevent.
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: