Closed Bug 383824 Opened 18 years ago Closed 18 years ago

Assertion: ASSERT: null node when dropping bookmark above or below "Bookmarks" folder

Categories

(Firefox :: Bookmarks & History, defect)

x86
Windows Vista
defect
Not set
major

Tracking

()

VERIFIED FIXED

People

(Reporter: stephend, Unassigned)

References

Details

Attachments

(1 file)

Build ID: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a6pre) Gecko/20070607 Minefield/3.0a6pre Summary: Assertion: ASSERT: null node when dropping bookmark above or below "Bookmarks" folder Steps to Reproduce: 1. In Bookmarks Manager, try to drag and drop a bookmark either above or below the "Bookmarks" folder Expected Results: (I'm new to the Bookmarks Manager rewrite (Places impl., so bear with me). I'd expect that if it were a disallowed operation, I would get the "no drop target" pointer; if allowed, of course, we shouldn't assert, and should presumably drop a copy of the bookmark. Actual Results: I'll attach the screenshot, which shows the assertion
Note that you must specifically drag/hover such that you invoke the blue ___ lines specifically showing the drop target positions (otherwise, no assert; just a silent failure).
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → DUPLICATE
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
(In reply to comment #3) > > *** This bug has been marked as a duplicate of bug 381751 *** > This bug isn't a duplicate, but does share one interesting difference... The position of the mouse is also related to the remaining falling-out-of-folder (see Comment #0 on #381751) issue: if you try to d/d a bookmark below the "Bookmarks" folder in the left pane, and your mouse cursor is actually hovering a pixel or two over the following folder, the icon drops fine. It is only when the mouse cursor hovers a pixel or two over the "Bookmarks" row that the assert happens.
Assignee: nobody → cyen
Status: REOPENED → NEW
stephen do you still see this issue?
Assignee: cyen → nobody
Depends on: 382679, 385970
(In reply to comment #5) > stephen do you still see this issue? Nope; please mark it FIXED, and I'll gladly verify. I tried multiple drag scenarios: * from the page proxy/favicon to the Bookmarks Manager (above the "Bookmarks" folder) * from the page proxy/favicon to the Bookmarks Manager (below the "Bookmarks" folder) * from the page proxy/favicon to the Bookmarks Manager (directly in the folder--just for a lark) * from within the right pane of the Bookmarks Manager itself to the "Bookmarks" folder (above it) * from within the right pane of the Bookmarks Manager itself to the "Bookmarks" folder (below it) * from within the right pane of the Bookmarks Manager itself (directly in the folder)
I thought it was cyen's fix, but from looking at your assertion screen shot, this is really something that mano fixed for bug #385614.
Status: NEW → RESOLVED
Closed: 18 years ago18 years ago
Depends on: 385614
No longer depends on: 382679, 385970
Resolution: --- → FIXED
(In reply to comment #7) > I thought it was cyen's fix, but from looking at your assertion screen shot, > this is really something that mano fixed for bug #385614. OK; in addition to comment 6, I also tried dragging from the History sidebar, as well as in-page web content/links. Verified FIXED using Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a6pre) Gecko/20070626 Minefield/3.0a6pre
Status: RESOLVED → VERIFIED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: