Closed
Bug 385871
Opened 17 years ago
Closed 17 years ago
DM needs to have schema checking
Categories
(Toolkit :: Downloads API, defect)
Toolkit
Downloads API
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha7
People
(Reporter: sdwilsh, Assigned: sdwilsh)
References
Details
Attachments
(1 file, 5 obsolete files)
(deleted),
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
Just like places and cookies does - we need the ability to upgrade and downgrade our database. Patch momentarily - just need to run a few tests and find a suitable reviewer.
Assignee | ||
Comment 1•17 years ago
|
||
Right now "PRAGMA user_version" returns 0 since we don't have one set. Hopefully that will address a question I'm sure my reviewer will have.
Assignee | ||
Updated•17 years ago
|
Attachment #269806 -
Flags: review?(mano)
Comment 2•17 years ago
|
||
Comment on attachment 269806 [details] [diff] [review]
v1.0
1. The db must be backed-up before dropping the moz_downloads table
2. s/PR_INT_MAX/DB_SCHEMA_VERSION +1
3. please add a comment explaining this downgrade case.
Attachment #269806 -
Flags: review?(mano) → review-
Assignee | ||
Updated•17 years ago
|
Assignee | ||
Comment 3•17 years ago
|
||
Attachment #269806 -
Attachment is obsolete: true
Attachment #270179 -
Flags: review?(mano)
Assignee | ||
Comment 4•17 years ago
|
||
whoops, gavin pointed out some typos that I forgot to fix. I think I got them this time.
Attachment #270179 -
Attachment is obsolete: true
Attachment #270182 -
Flags: review?(mano)
Attachment #270179 -
Flags: review?(mano)
Assignee | ||
Updated•17 years ago
|
Attachment #270182 -
Attachment is obsolete: true
Attachment #270182 -
Flags: review?(mano)
Assignee | ||
Comment 6•17 years ago
|
||
No really, I think this one is right...
Attachment #270368 -
Attachment is obsolete: true
Attachment #270393 -
Flags: review?(mano)
Attachment #270368 -
Flags: review?(mano)
Assignee | ||
Comment 7•17 years ago
|
||
Whoops, I did this on the plane but forgot to upload it...
Attachment #270393 -
Attachment is obsolete: true
Attachment #270694 -
Flags: review?(mano)
Attachment #270393 -
Flags: review?(mano)
Comment 8•17 years ago
|
||
Comment on attachment 270694 [details] [diff] [review]
v1.5
s/if (NS_FAILED(rv)) return rv;/NS_ENSURE_SUCCESS(rv, rv);/
r=mano, looks good except the } else { convention of this file ;)
Attachment #270694 -
Flags: review?(mano) → review+
Assignee | ||
Comment 9•17 years ago
|
||
Checking in toolkit/components/downloads/src/nsDownloadManager.cpp;
new revision: 1.95; previous revision: 1.94
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Updated•17 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•