Closed
Bug 385875
Opened 17 years ago
Closed 17 years ago
Remove image url from being stored in the DM
Categories
(Toolkit :: Downloads API, defect)
Toolkit
Downloads API
Tracking
()
RESOLVED
FIXED
mozilla1.9alpha7
People
(Reporter: sdwilsh, Assigned: sdwilsh)
References
Details
Attachments
(2 files)
(deleted),
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
(deleted),
application/octet-stream
|
Details |
It used to be used by the XPInstall bits, but those are gone. Originally, I suggested removing it in Bug 380250, but Mano had pointed out that XPInstall did in fact use it.
Once the schema stuff lands, we can drop support for that column. This will result in a size win for the database.
Assignee | ||
Comment 1•17 years ago
|
||
Complete with unit tests! I think in a follow-up bug I want to move the migration testing and upgrading/downgrading code into a separate file to keep nsDownloadManager.cpp a bit cleaner.
I'll attach the sqlite db that needs to be landed with this in just a moment.
Assignee | ||
Comment 2•17 years ago
|
||
Assignee | ||
Comment 3•17 years ago
|
||
For reference - I did this how sqlite docs recommend to remove a column:
http://www.sqlite.org/faq.html#q11
Comment 4•17 years ago
|
||
Comment on attachment 273215 [details] [diff] [review]
v1.0
r=mano
Attachment #273215 -
Flags: review?(mano) → review+
Assignee | ||
Comment 5•17 years ago
|
||
I managed to forget to include my Makefile.in changes in the patch (just adds the additional test directory). Got it in the commit.
Checking in toolkit/components/downloads/public/nsIDownloadManager.idl;
new revision: 1.14; previous revision: 1.13
Checking in toolkit/components/downloads/src/nsDownloadProxy.h;
new revision: 1.20; previous revision: 1.19
Checking in toolkit/components/downloads/src/nsDownloadManager.h;
new revision: 1.32; previous revision: 1.31
Checking in toolkit/components/downloads/src/nsDownloadManager.cpp;
new revision: 1.98; previous revision: 1.97
Checking in toolkit/components/downloads/test/unit/head_download_manager.js;
new revision: 1.4; previous revision: 1.3
Checking in toolkit/components/downloads/test/unit/test_bug_381535.js;
new revision: 1.2; previous revision: 1.1
Checking in toolkit/components/downloads/test/unit/test_download_manager_migration.js;
new revision: 1.9; previous revision: 1.8
Checking in toolkit/components/downloads/test/schema_migration/head_migration.js;
initial revision: 1.1
Checking in toolkit/components/downloads/test/schema_migration/test_migration_to_2.js;
initial revision: 1.1
Checking in toolkit/components/downloads/test/Makefile.in;
new revision: 1.4; previous revision: 1.3
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•17 years ago
|
Flags: in-testsuite+
Target Milestone: --- → Firefox 3 M7
Assignee | ||
Comment 6•17 years ago
|
||
d'oh...
Checking in toolkit/components/downloads/test/schema_migration/v1.sqlite;
initial revision: 1.1
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•