Closed
Bug 387489
Opened 17 years ago
Closed 17 years ago
talos should auto-detect the OS
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: myk, Assigned: myk)
References
Details
Attachments
(1 file)
(deleted),
patch
|
rhelmer
:
review+
|
Details | Diff | Splinter Review |
Talos relies on the "OS" configuration variable in config.py to tell it what OS it's running on, but it's easy to figure that out from sys.platform, os.name, or platform.system(). Talos should automatically detect the OS via one of those.
Assignee | ||
Comment 1•17 years ago
|
||
Here's a patch that replaces references to config.OS with references to platform.system().
platform.system() seems more compatible with the way we currently differentiate between OSes than sys.platform (which returns "linux2" for my version of Linux and presumably returns "Linux1" for some versions) and os.name (which returns "posix" for both Linux and Mac).
Per section 14.12.1 "Cross Platform" in the Python Library Reference <http://docs.python.org/lib/node442.html>, this method returns "the system/OS name, e.g. 'Linux', 'Windows', or 'Java'". On my Mac OS X 10.4.10 installation it returns "Darwin".
Section 14.12 "platform" <http://docs.python.org/lib/module-platform.html> says the module is new in Python version 2.3, which is less than (for Windows) or equal to (for Mac, per the patch in bug 384341) the minimum version of Python Talos requires, so it should be available on all systems Talos runs on.
Comment 2•17 years ago
|
||
Comment on attachment 271592 [details] [diff] [review]
patch v1: replaces config.OS with platform.system()
this looks good to me; what do you think alice?
Attachment #271592 -
Flags: superreview?(anodelman)
Attachment #271592 -
Flags: review?(rhelmer)
Attachment #271592 -
Flags: review+
Comment 3•17 years ago
|
||
My only concern would be, mostly due to my unfamiliarity with platform.system, that we are using exact equals to identify linux, windows, etc. Will it always report back as "Linux" for various flavors of linux? Will Vista and XP report as "Windows"?
The doc states:
"
The output is intended to be human readable rather than machine parseable. It may look different on different platforms and this is intended.
"
I'm just worried that we could run into some sort of Linux/linux/bsd/Fedora mess.
Assignee | ||
Comment 4•17 years ago
|
||
> The doc states:
> "
> The output is intended to be human readable rather than machine parseable. It
> may look different on different platforms and this is intended.
> "
Actually, that's the description of platform.platform(). platform.system(), on the other hand, is described as follows:
"
Returns the system/OS name, e.g. 'Linux', 'Windows', or 'Java'. An empty string is returned if the value cannot be determined.
"
I should note that ffprocess_mac.py and ffprofile_mac.py from the patch in bug 384341 are very similar to the Linux versions of those files. I wonder whether it would make more sense to use single files for all platforms and implement branching code where necessary within the files themselves. But that's an issue for another bug.
Comment 5•17 years ago
|
||
Comment on attachment 271592 [details] [diff] [review]
patch v1: replaces config.OS with platform.system()
This looks good to me, after the clarification of my misreading of the docs.
We may want to add some failure case for if/when platform.system() returns an empty string.
Attachment #271592 -
Flags: superreview?(anodelman) → superreview+
Assignee | ||
Comment 6•17 years ago
|
||
Checking in ffprocess.py;
/cvsroot/mozilla/testing/performance/talos/ffprocess.py,v <-- ffprocess.py
new revision: 1.3; previous revision: 1.2
done
Checking in ffprofile.py;
/cvsroot/mozilla/testing/performance/talos/ffprofile.py,v <-- ffprofile.py
new revision: 1.3; previous revision: 1.2
done
Checking in tp.py;
/cvsroot/mozilla/testing/performance/talos/tp.py,v <-- tp.py
new revision: 1.6; previous revision: 1.5
done
Checking in config.py;
/cvsroot/mozilla/testing/performance/talos/config.py,v <-- config.py
new revision: 1.5; previous revision: 1.4
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Comment 7•16 years ago
|
||
Mass move of Core:Testing bugs to mozilla.org:Release Engineering:Talos. Filter on RelEngTalosMassMove to ignore.
Component: Testing → Release Engineering: Talos
Product: Core → mozilla.org
QA Contact: testing → release
Version: Trunk → other
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•