Closed
Bug 391800
Opened 17 years ago
Closed 17 years ago
left panel view should be able to pass a more than one subject to right panel view
Categories
(Other Applications :: DOM Inspector, defect)
Other Applications
DOM Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: surkov, Assigned: surkov)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
If I watch accessible tree view in left panel then if I choose in left panel
1) accessible-related view then subject should be accessible object
2) DOMNode-related view then subject should DOMNode
Now subject is always DOMNode. It leads we can't watch accessible views for some accessible objects. For example, accessibles for tree/treeitems share one and the same DOM node so if subject is DOM node then we always get accessible object for tree via nsIAccessibilityService.
Assignee | ||
Comment 1•17 years ago
|
||
Assignee: vasiliy.potapenko → surkov.alexander
Status: NEW → ASSIGNED
Attachment #277549 -
Flags: superreview?(neil)
Attachment #277549 -
Flags: review?
Assignee | ||
Updated•17 years ago
|
Attachment #277549 -
Flags: review? → review?(comrade693+bmo)
Comment 2•17 years ago
|
||
Comment on attachment 277549 [details] [diff] [review]
patch
Sorry, but I don't see any real code changes in this patch.
Attachment #277549 -
Flags: superreview?(neil)
Comment 3•17 years ago
|
||
Comment on attachment 277549 [details] [diff] [review]
patch
I'm with Neil on this one - rs=sdwilsh
Attachment #277549 -
Flags: review?(comrade693+bmo)
Assignee | ||
Comment 4•17 years ago
|
||
real code changes are:
1) in accessibleTree.js to set an accessible for dom node as user data
2) in accessibleObject.js/accessibleProperties.js to get an accessible from dom object as user data.
It allows to pass accessible obect from left view to the right view. The bug sounds a bit wider but that's all I want. This patch make correct the navigation through the accessible tree.
Assignee | ||
Comment 5•17 years ago
|
||
(In reply to comment #3)
> (From update of attachment 277549 [details] [diff] [review])
> I'm with Neil on this one - rs=sdwilsh
>
What is rs=sdwilsh?
Assignee | ||
Comment 6•17 years ago
|
||
Comment on attachment 277549 [details] [diff] [review]
patch
rerequesting
Attachment #277549 -
Flags: superreview?(neil)
Attachment #277549 -
Flags: review?(comrade693+bmo)
Comment 7•17 years ago
|
||
rs == rubber-stamp approval
Comment 8•17 years ago
|
||
Comment on attachment 277549 [details] [diff] [review]
patch
(In reply to comment #5)
> What is rs=sdwilsh?
It means you don't need r or sr and are free to check this in. rs is rubber stamp.
Attachment #277549 -
Flags: superreview?(neil)
Attachment #277549 -
Flags: review?(comrade693+bmo)
Assignee | ||
Comment 9•17 years ago
|
||
(In reply to comment #8)
> (From update of attachment 277549 [details] [diff] [review])
> (In reply to comment #5)
> > What is rs=sdwilsh?
> It means you don't need r or sr and are free to check this in. rs is rubber
> stamp.
>
Ah, ok. Thank you.
Assignee | ||
Comment 10•17 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•