User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.2) Gecko/20070222 SeaMonkey/1.1.1 Mnenhy/0.7.5.0 Build Identifier: ChatZilla 0.9.78.1-rdmsoft [XULRunner 1.8.0.9/2006120508] The FAQ (URL above) shows 18 emoticons, but there are actually 26 images in the images folder of the skin, and 21 in the munger.js. Missing in the FAQ: - alien (present in munger.js) - arrow - exclamation - idea - mrgreen - dizzy-back (present in munger.js) and, not sure: - razz - rofl (present in munger.js) Reproducible: Always Steps to Reproduce: 1. 2. 3. Expected Results: - Could the FAQ be updated to show how to get the 21 emoticons from munger.js ? - Could munger.js add the 5 missing ? (I suppose this should be another bug)

OK, so any not in mungers.js have currently no suitable text to match. Ideas welcome for them. dizzy-back is the left-right flipped version of dizzy (O_o vs. o_O). I don't see any reason this should be in the FAQ, it's just a nicety (we'd have matched them all to one image if we hadn't made the extra one). ROFL was an additional one added later, and can probably be added. Alien is an easter-egg, damnit! :P

The arrow could be something like :-> maybe, or :>> If the "question" smiley is :-? it would make sense to get the exclamation one with :-! The idea: :-I MrGreen: :-G or :~G I don't know what "razz" is so I have no suggestion for it ;-)

"ROFL" is already in there (it's the x-D one). So that leaves us with nothing to add to the FAQ (assuming we want to keep the alien an easter egg). I'm not sure we should have the arrow, question mark or exclamation mark at all. I guess I'd prefer to cvs rm those files instead of adding them to the munger "just for sakes". I also don't really see the point of mister green (and/or how it's supposed to be different from :D ) and I don't think the idea one is in regular use as a text smilie. That is, as far as I'm concerned we should only have smilies as image representations of something that makes sense as text, not go looking all over the place for textual representations of an image - in particular because they might not work well with what other clients (or people!) would interpret those smilies to mean. (eg. ":-I" could be lots of other things) I'd be happy to hear from people who disagree :-).

Nobody's complaining so far, so I propose we remove these smilies from the xpi/jar and output-base.css . We could cvs remove the files but I'm not sure that's worth it. If so, we should also remove the old backgrounds and lights which are still in there without being used (blue rock and friends).

Comment on attachment 288306 [details] [diff] [review] Remove excessive smilies from jar and output-base face-question is used! Don't remove that one from either file. r=silver on the others.

Checking in mozilla/extensions/irc/jar.mn; /cvsroot/mozilla/extensions/irc/jar.mn,v <-- jar.mn new revision: 1.35; previous revision: 1.34 done Checking in mozilla/extensions/irc/xul/content/output-base.css; /cvsroot/mozilla/extensions/irc/xul/content/output-base.css,v <-- output-base.css new revision: 1.15; previous revision: 1.14 done