The access keys for the following items are missing: * Search -> Find Next * View -> Browser * View -> Blink Selected Element * The Inspect button

This patch is fairly trivial... I was not sure who to ask for review. timeless, please let me know if this is not appropriate for you. Also, I was not sure if this needs super-review or not.

This does need sr, and you picked the right one. If timeless doesn't get to this in a timely matter, I can also do the review.

Comment on attachment 283606 [details] [diff] [review] Add the access keys This won't build as it stands because you added entities in en-US only. (Sorry, I don't know what correct procedure is here.)

I think the correct procedure is to disable the non-en-US locales (by commenting them out in http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/extensions/inspector/resources/Makefile.in&rev=1.39&mark=47-54#47), land the en-US changes, and notify the localizers of the change (using the newsgroup or by CCing the aliases to the bug).

OK, here's a new patch disabling all locales except en-US in the Makefile. Gavin, what are the CC's for the respective l10n teams so that we can notify them? (I assume this needs requesting sr again...)

(In reply to comment #5) > Gavin, what are the CC's for the respective l10n teams so that we can notify > them? I know "firefoxl10n@hotmail.com" is watched by at least some Firefox localizers, but I'm not sure that that's sufficient (or how that overlaps with DOMi localizers). You'd have to ask Axel, I guess... probably best to just post to the mozilla.dev.l10n newsgroup.

Comment on attachment 283679 [details] [diff] [review] Add the access keys & disable non en-US locales in the Makefile In the past it has been sufficient to remove the locales from the Makefile, and the localizers have been very quick in picking it up.

Checking in extensions/inspector/resources/Makefile.in; /cvsroot/mozilla/extensions/inspector/resources/Makefile.in,v <-- Makefile.in new revision: 1.46; previous revision: 1.45 done Checking in extensions/inspector/resources/content/popupOverlay.xul; /cvsroot/mozilla/extensions/inspector/resources/content/popupOverlay.xul,v <-- popupOverlay.xul new revision: 1.19; previous revision: 1.18 done Checking in extensions/inspector/resources/content/toolboxOverlay.xul; /cvsroot/mozilla/extensions/inspector/resources/content/toolboxOverlay.xul,v <-- toolboxOverlay.xul new revision: 1.16; previous revision: 1.15 done Checking in extensions/inspector/resources/content/viewers/dom/popupOverlay.xul; /cvsroot/mozilla/extensions/inspector/resources/content/viewers/dom/popupOverlay.xul,v <-- popupOverlay.xul new revision: 1.10; previous revision: 1.9 done Checking in extensions/inspector/resources/locale/en-US/inspector.dtd; /cvsroot/mozilla/extensions/inspector/resources/locale/en-US/inspector.dtd,v <-- inspector.dtd new revision: 1.12; previous revision: 1.11 done Checking in extensions/inspector/resources/locale/en-US/viewers/dom.dtd; /cvsroot/mozilla/extensions/inspector/resources/locale/en-US/viewers/dom.dtd,v <-- dom.dtd new revision: 1.14; previous revision: 1.13 done