Closed Bug 399653 Opened 17 years ago Closed 17 years ago

Insert Node dialog can't create HTML elements

Categories

(Other Applications :: DOM Inspector, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: neil, Assigned: takenspc)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

dom.js only uses createElementNS to create elements but that can't create HTML elements, only XHTML elements. My personal preference would be for Insert Node to create HTML elements. However the insert node dialog returns no namespace for HTML documents, so I can't even create XHTML elements as a workaround.
Attached patch Patch (obsolete) (deleted) — Splinter Review
Patch. I replaced some tabs to spaces (|dom.js|) because I need to change indent level (|if| ~ |else|). # There are some tabs still.
Assignee: nobody → taken.spc
Status: NEW → ASSIGNED
Attachment #308816 - Flags: review?(db48x)
(In reply to comment #1) >Created an attachment (id=308816) Hmm, so I think it might be better to move the enableNamespaces function into dom.js and pass it in as one of the attr parameters. > # There are some tabs still. Eww, who put them there :-(
Blocks: 420105
Attached patch Patch v2 (deleted) — Splinter Review
make |enableNamespaces| to just a property instead of a function.
Attachment #308816 - Attachment is obsolete: true
Attachment #308941 - Flags: review?(db48x)
Attachment #308816 - Flags: review?(db48x)
Comment on attachment 308941 [details] [diff] [review] Patch v2 r=db48x, though if there are still tabs anywhere in the file you might as well go ahead and get rid of them (any decent editor can automate the task)
Attachment #308941 - Flags: review?(db48x) → review+
Comment on attachment 308941 [details] [diff] [review] Patch v2 Yes, the property looks much better, thanks!
Attachment #308941 - Flags: superreview+
I don't have cvs commit access. Could someone check this in the tree?
Keywords: checkin-needed
Checking in extensions/inspector/resources/content/viewers/dom/dom.js; /cvsroot/mozilla/extensions/inspector/resources/content/viewers/dom/dom.js,v <-- dom.js new revision: 1.52; previous revision: 1.51 done Checking in extensions/inspector/resources/content/viewers/dom/insertDialog.js; /cvsroot/mozilla/extensions/inspector/resources/content/viewers/dom/insertDialog.js,v <-- insertDialog.js new revision: 1.2; previous revision: 1.1 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Version: unspecified → Trunk
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: