Closed
Bug 400475
Opened 17 years ago
Closed 17 years ago
"ASSERTION: dangling frame without a content node" changing any attribute on <math:mstyle>
Categories
(Core :: MathML, defect)
Core
MathML
Tracking
()
RESOLVED
FIXED
mozilla1.9beta3
People
(Reporter: jruderman, Assigned: vladimir.sukhoy)
References
Details
(Keywords: assertion, testcase)
Attachments
(2 files)
|
(deleted),
application/xhtml+xml
|
Details | |
|
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
mtschrep
:
approval1.9+
|
Details | Diff | Splinter Review |
Loading the testcase triggers:
###!!! ASSERTION: dangling frame without a content node: 'content', file /Users/jruderman/trunk/mozilla/layout/mathml/base/src/nsMathMLFrame.cpp, line 236
Split from bug 353612.
|
Assignee | |
Comment 1•17 years ago
|
||
Looks like the code in nsMathMLFrame::GetPresentationDataFrom walks all the way up to the root frame which has no content. What if we just disable the assert for the top-level frame?
|
|
Assignee | |
Comment 2•17 years ago
|
||
Do you want to get review on this?
|
|
Assignee | |
Comment 4•17 years ago
|
||
err, sorry for late response (was travelling..), initially I did, but now I am not up-to-date with the trunk, given that how much was changed with MathML recently. Mostly, I was not sure if it is ok or not ok for the frame to have null content, if it is ok then probably I do want a review on that..
Comment on attachment 286252 [details] [diff] [review]
like so
The viewport frame (the one with no parent) does have no content pointer (which is bogus, but that's how it is for now). So this is good.
Attachment #286252 -
Flags: superreview+
Attachment #286252 -
Flags: review+
|
|
Assignee | |
Comment 6•17 years ago
|
||
Comment on attachment 286252 [details] [diff] [review]
like so
given that this bug blocks bug 347580 which I cannot even look at due to lack of privileges, requesting approval on the patch..
Attachment #286252 -
Flags: approval1.9?
|
||
Updated•17 years ago
|
Attachment #286252 -
Flags: approval1.9? → approval1.9+
|
||
Updated•17 years ago
|
Assignee: rbs → vladimir.sukhoy
|
|
||
Updated•17 years ago
|
QA Contact: ian → mathml
|
|
||
Updated•17 years ago
|
Keywords: checkin-needed
|
|
||
Comment 7•17 years ago
|
||
Checking in layout/mathml/base/src/nsMathMLFrame.cpp;
/cvsroot/mozilla/layout/mathml/base/src/nsMathMLFrame.cpp,v <-- nsMathMLFrame.cpp
new revision: 1.77; previous revision: 1.76
done
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
OS: Mac OS X → All
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11
|
||
Updated•17 years ago
|
Flags: in-testsuite?
You need to log in
before you can comment on or make changes to this bug.
Description
•