Closed
Bug 403718
Opened 17 years ago
Closed 17 years ago
render mroot and msqrt appropriately when radical glyphs are above the baseline (ascent != overline thickness)
Categories
(Core :: MathML, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla1.9beta2
People
(Reporter: karlt, Assigned: karlt)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
(deleted),
image/png
|
Details |
Radical glyphs from TeX fonts and some of the radical glyphs from
Mathematica fonts are drawn below the baseline so that their ascent contains information about the thickness of the overline.
Most fonts (including STIXGeneral STIXSize* CambriaMath), however, have radical glyphs above the baseline so no such assumption can be made about the meaning of their ascent.
Flags: blocking1.9?
Assignee | ||
Comment 1•17 years ago
|
||
Even with the glyphs from Mathematica's Math2, the overline rule and the right hook from the radical glyph sometimes don't have the same thickness (if font sizes are chosen carefully/poorly), so I see no need to continue to use this method.
Assignee | ||
Comment 2•17 years ago
|
||
Assignee | ||
Updated•17 years ago
|
Priority: -- → P1
Comment 3•17 years ago
|
||
is this a regression? suggestions for priority?
Flags: blocking1.9? → blocking1.9+
Assignee | ||
Comment 4•17 years ago
|
||
(In reply to comment #3)
Strictly, this it not a regression as this never worked for "normal" fonts.
However the "special" fonts now don't work either, which is a regression.
I've prioritized P1 as this blocks fixing that regression (by using more modern fonts, bug 400938).
Assignee | ||
Comment 5•17 years ago
|
||
Just using GetRuleThickness for overline thickness, and shifted some code around so that radical height is stretched using the adjusted overline thickness and rounded clearance.
With this change, there is no need for specifying special fonts for sqrt, hence the change to the mathfont.properties file.
Attachment #288599 -
Flags: review?(roc)
Assignee | ||
Comment 6•17 years ago
|
||
There are still some issues with the overline rule and the right
hook from the radical top not lining up perfectly.
This may be due to rounding in FillRect or aligning the glyphs to pixels.
Perhaps the correct fix is to use glyphs from the font (where available) for the overline rule.
An alternative is to just use verticals for the radical top and position the overline based on the right bearing rather than the advance width.
Fixing that can be an enhancement for later.
Attachment #288599 -
Flags: superreview+
Attachment #288599 -
Flags: review?(roc)
Attachment #288599 -
Flags: review+
Assignee | ||
Comment 7•17 years ago
|
||
Checked in:
1.18 mozilla/layout/mathml/base/src/mathfont.properties
1.132 mozilla/layout/mathml/base/src/nsMathMLChar.cpp
1.55 mozilla/layout/mathml/base/src/nsMathMLmrootFrame.cpp
1.47 mozilla/layout/mathml/base/src/nsMathMLmsqrtFrame.cpp
Filed bug 403958 for perfecting the issues mentioned in the previous comment.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•17 years ago
|
Target Milestone: --- → mozilla1.9 M10
You need to log in
before you can comment on or make changes to this bug.
Description
•