Closed
Bug 40461
Opened 24 years ago
Closed 24 years ago
implement NS_ConvertUCS2toUTF8()
Categories
(Core :: XPCOM, defect, P1)
Core
XPCOM
Tracking
()
VERIFIED
FIXED
M17
People
(Reporter: waterson, Assigned: waterson)
References
Details
Attachments
(3 files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
Provide UCS2-to-UTF8 conversion (other than the always-allocating
ToNewUTF8String).
Assignee | ||
Comment 1•24 years ago
|
||
Assignee | ||
Comment 2•24 years ago
|
||
Assignee | ||
Comment 3•24 years ago
|
||
Please ignore patch #1. I had the "hand off ownership" done wrong in
ToNewUTF8String(), and had also carried over a bug with first-pass length
calculation from the original source.
Assignee | ||
Comment 4•24 years ago
|
||
ftang: could you also take a look at these changes? I'm re-implementing
ToNewUTF8String() in terms of a global helper class, NS_ConvertUCS2toUTF8().
N.B. that I think I fixed a bug with UTF-8 first-pass length calculation as
well (you had the masks inverted bitwise).
Assignee | ||
Comment 5•24 years ago
|
||
I need this for 10373, and probably 28787, too. Can I get transitive closure of
[nsbeta+] from these bugs, please?
Assignee | ||
Updated•24 years ago
|
Status: NEW → ASSIGNED
Priority: P3 → P1
Target Milestone: --- → M17
Comment 6•24 years ago
|
||
These changes look reasonable, but be aware that I will probably later refactor
to move the work of the |Init| method to a function |NS_CopyUCS2toUTF8( const
nsAReadableString& aUCS2source, nsAWritableCString& aUTF8destination )|, which I
will then call from |Init|. This work will actually be done by creating a
special char-sink so that all the work is done in |copy_string|.
If you have some reasonable tests cases, and this code passes, check in at will.
Assignee | ||
Comment 7•24 years ago
|
||
Comment 8•24 years ago
|
||
Didn't I convince you guys to follow the nsFoo class-naming convention?
/be
Assignee | ||
Comment 9•24 years ago
|
||
fix checked in, r=scc,brendan
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Comment 10•24 years ago
|
||
- Per last comments, age of bug, and no reopen - Marking Verified/Fixed. Please
reopen if still a problem.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•