Closed Bug 40601 Opened 24 years ago Closed 24 years ago

RDFServiceImpl::GetUnicodeResource does wrong munging

Categories

(Core Graveyard :: RDF, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: vishy, Assigned: waterson)

References

Details

Attachments

(2 files)

From Bugzilla Helper: User-Agent: Mozilla/4.72 [en] (WinNT; U) BuildID: All RDFServiceImpl::GetUnicodeResource munges non-ascii, non-latin1 unicode uris by changing every char > 255 to a '.'. This is problematic. We should instead do the munging by converting from Unicode to a UTF8 string. Otherwise many Intl uris will all map to the same resource inadvertently. Reproducible: Always Steps to Reproduce: 1. Do GetUnicodeResource for two different Japanese PRUnichar* uris. 2. They will likely map to the same resource even if they are very different. Actual Results: This means that we cannot use Japanese group names in Instant Messenger (unless we do some ugly UTF-8 mangling in our code instead). The right place for that to be done is in RDF itself as other people can hit this too in the future.
Need to check in changes for bug 40461 to implement this efficiently.
Depends on: 40461
Attached patch Patch for change (NOT COMPLETE) (deleted) — Splinter Review
The patch attached before indicates what I would like the behavious of GetUnicodeResource to be - however it is NOT CORRECT. Applying this patch means the browser doesnt even start and lots of assertions. Looks like the URI munging algorithm is used elsewhere in the RDF code or elsewhere ? Bugscape 1025 [nsbeta2+] depends on this bug, so I'm nominating it for nsbeta2 as well. Thanks, Vishy
Keywords: nsbeta2
Status: NEW → ASSIGNED
Target Milestone: --- → M17
Fix checked in.
oops. marking fixed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
tever is not RDF QA anymore
QA Contact: tever → nobody
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: