Closed
Bug 404769
Opened 17 years ago
Closed 17 years ago
Tweak tab border colors
Categories
(Firefox :: Tabbed Browser, defect, P4)
Tracking
()
RESOLVED
FIXED
Firefox 3 beta3
People
(Reporter: rflint, Assigned: dao)
References
Details
(Keywords: regression)
Attachments
(4 files, 1 obsolete file)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
patch
|
rflint
:
review+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
(deleted),
image/png
|
Details |
Once we've got a Txul baseline with the current implementation, the tab border colors should be swapped out for ones specified using rgba(), nsLookAndFeel and friends.
Comment 1•17 years ago
|
||
Are the borders for unselected tabs going to remain at 2px? They look quite jarring. Can't we reduce it to 1px like its for hovered and active tabs?
Assignee | ||
Updated•17 years ago
|
Flags: blocking-firefox3?
Comment 2•17 years ago
|
||
Wanted, not blocking, since this seems like a fairly trivial cosmetic bug.
Flags: wanted-firefox3+
Flags: blocking-firefox3?
Flags: blocking-firefox3-
Priority: -- → P4
Target Milestone: --- → Firefox 3 M11
Assignee | ||
Comment 4•17 years ago
|
||
Assignee | ||
Comment 5•17 years ago
|
||
The patch contains some serious cleanup (i.e. it's not fairly trivial cosmetic). I didn't plan to do this, but eventually it's all related to each other somehow.
Assignee | ||
Comment 6•17 years ago
|
||
Doesn't show the full impact of the patch, but you should get a brief impression at least.
Assignee | ||
Comment 7•17 years ago
|
||
We've been using semi-transparent borders (within the images) before, so the current opaque colors are actually an OS integration regression.
Keywords: regression
Assignee | ||
Comment 8•17 years ago
|
||
found a small glitch with a dark OS theme
Attachment #295580 -
Attachment is obsolete: true
Attachment #295673 -
Flags: review?(rflint)
Attachment #295580 -
Flags: review?(rflint)
Assignee | ||
Comment 9•17 years ago
|
||
Reporter | ||
Updated•17 years ago
|
Attachment #295673 -
Flags: review?(rflint)
Attachment #295673 -
Flags: review+
Attachment #295673 -
Flags: approval1.9?
Comment 10•17 years ago
|
||
Comment on attachment 295673 [details] [diff] [review] patch v2 a=beltzner for 1.9
Attachment #295673 -
Flags: approval1.9? → approval1.9+
Reporter | ||
Comment 11•17 years ago
|
||
mozilla/browser/themes/winstripe/browser/browser.css 1.145 mozilla/browser/themes/winstripe/browser/jar.mn 1.64 mozilla/browser/themes/winstripe/browser/tabbrowser/alltabs-box-overflow-end-bkgnd-animate.png 1.3
Assignee: rflint → dao
Status: ASSIGNED → NEW
Reporter | ||
Updated•17 years ago
|
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•