Closed
Bug 387345
Opened 18 years ago
Closed 17 years ago
Restyle the tabstrip
Categories
(Firefox :: Tabbed Browser, defect, P5)
Firefox
Tabbed Browser
Tracking
()
VERIFIED
FIXED
Firefox 3 beta2
People
(Reporter: rflint, Assigned: rflint)
References
(Depends on 1 open bug)
Details
(Keywords: perf)
Attachments
(1 file)
(deleted),
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
Quasi-meta bug to cover the work needed to:
- Eliminate the fixed height images (bug 350194)
- Draw borders with border-radius where appropriate
- Reduce the number of separate images needed
- Reduce Ts/Txul impact
Updated•17 years ago
|
Flags: blocking-firefox3?
Assignee | ||
Comment 2•17 years ago
|
||
(In reply to comment #1)
> Border-radius isn't anti-aliased on Linux, is it?
>
I don't believe so and mconnor asked me to check that out just yesterday ;)
Background layering would be nice, but that's not likely to happen for 1.9. I was hoping to just get away with using border-image.
Depends on: 378217
Comment 3•17 years ago
|
||
I was testing with padding-left / padding-right (i.e. no extra xul boxes), one background image and border-radius on Windows, and compared to the current appearance I couldn't really tell a difference. If border-radius could be fixed on Linux, I think that would be the ideal solution.
Assignee | ||
Comment 4•17 years ago
|
||
(In reply to comment #3)
True, it's barely noticeable: http://screwedbydesign.com/images/csstabs.png (note: really old image) and something we might be willing to do without if it comes down to it.
Comment 5•17 years ago
|
||
I'd rather use native tabs on Linux if we can't get the current tabs done, because this is a real perf win...
Updated•17 years ago
|
Flags: blocking-firefox3? → blocking-firefox3+
Updated•17 years ago
|
Target Milestone: Firefox 3 → Firefox 3 M10
Updated•17 years ago
|
Target Milestone: Firefox 3 M10 → Firefox 3 M11
Updated•17 years ago
|
Priority: -- → P5
Assignee | ||
Comment 6•17 years ago
|
||
This takes care of winstripe and gnomestripe (already landed) - I'll file a followup for sticking a band-aid on pinstripe until the new theme's in.
Attachment #288618 -
Flags: review?(mconnor)
Comment 7•17 years ago
|
||
I think you should use rgba() or native ThreeD* colors; either way would be better than static opaque colors.
Comment 8•17 years ago
|
||
(In reply to comment #7)
> I think you should use rgba() or native ThreeD* colors; either way would be
> better than static opaque colors.
for the tab borders
Assignee | ||
Comment 9•17 years ago
|
||
Yes, that's my plan - but since rgba() hasn't really been used at all in the UI, I want an established perf baseline with the other bits from this patch before mucking with it.
Comment 10•17 years ago
|
||
OK, but for the selected tab we should probably use ThreeDShadow anyway.
Comment 11•17 years ago
|
||
(In reply to comment #10)
> OK, but for the selected tab we should probably use ThreeDShadow anyway.
or ThreeDDarkShadow actually
Comment 13•17 years ago
|
||
Comment on attachment 288618 [details] [diff] [review]
Patch
I'm a tad nervous about the colors for the borders, but I'm otherwise ok with this.
I assume this doesn't break Mac, correct?
Attachment #288618 -
Flags: review?(mconnor) → review+
Assignee | ||
Comment 14•17 years ago
|
||
mozilla/browser/base/content/browser.css 1.40
mozilla/browser/base/content/tabbrowser.xml 1.251
mozilla/browser/themes/winstripe/browser/browser.css 1.135
mozilla/browser/themes/winstripe/browser/jar.mn 1.61
mozilla/browser/themes/winstripe/browser/tabbrowser/tab-active-bkgnd.png 1.1
mozilla/browser/themes/winstripe/browser/tabbrowser/tab-bkgnd.png 1.1
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: Firefox 3 Mx → Firefox 3 M10
Assignee | ||
Comment 15•17 years ago
|
||
The windows box is still a bit jumpy (though talos seems to confirm similar drops), but so far it looks like the results are as follows:
Ts before: ~1870ms
Ts after: ~1830ms
Txul before: ~469ms
Txul after: ~450ms
Updated•17 years ago
|
Comment 16•17 years ago
|
||
This was a 2% Ts win and 4% Txul improvement even though the tab bar isn't shown by default? Wow.
Updated•17 years ago
|
Updated•17 years ago
|
Comment 17•17 years ago
|
||
Hi ryan, do you have a testcase for this bug so QA can verify this fix?
Comment 19•17 years ago
|
||
Dao, since this is code cleanup, can you confirm this is fixed in latest builds? Thanks.
Comment 20•17 years ago
|
||
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b3pre) Gecko/2007121405 Minefield/3.0b3pre
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•