Closed Bug 408322 Opened 17 years ago Closed 17 years ago

right click, bookmark this link doesn't bookmark the link

Categories

(Firefox :: Bookmarks & History, defect, P2)

defect

Tracking

()

VERIFIED FIXED
Firefox 3 beta3

People

(Reporter: moco, Assigned: philor)

References

Details

(Keywords: regression)

Attachments

(1 file)

right click, bookmark this link doesn't bookmark the link
Flags: blocking-firefox3?
in my console, I'm seeing: Error: PlacesUtils.ptm.commitTransaction is not a function Source File: chrome://browser/content/browser.js Line: 5396
Keywords: regression
OS: Windows XP → All
Priority: -- → P2
Hardware: PC → All
Target Milestone: --- → Firefox 3 M11
Blocks: 390739
Attached patch Fix v.1 (deleted) — Splinter Review
do de do
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #293090 - Flags: review?(mano)
Interesting that it's been broken for going on 11 days without anyone noticing, or hitting it in a Litmus test. I sort of vaguely thought it was a smoketest, back before Places Mark I left it broken for several months.
Flags: in-litmus?
the litmus feedback loop is too slow. we should be taking advantage of the browser mochitests for these basic cases.
Comment on attachment 293090 [details] [diff] [review] Fix v.1 r=sspitzer, thanks Phil.
Attachment #293090 - Flags: review?(mano)
Attachment #293090 - Flags: review+
Attachment #293090 - Flags: approval1.9?
let's heed dietrich's advice and work on a test.
Flags: in-testsuite?
Comment on attachment 293090 [details] [diff] [review] Fix v.1 a=beltzner
Attachment #293090 - Flags: approval1.9? → approval1.9+
fixed, thanks Phil. Checking in browser/base/content/browser-places.js; /cvsroot/mozilla/browser/base/content/browser-places.js,v <-- browser-places.j s new revision: 1.73; previous revision: 1.72 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
whoops, Phil has cvs access, so I should have let him check his own patch in. (Sorry Phil, won't happen again)
Flags: blocking-firefox3? → blocking-firefox3+
Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2007122704 Minefield/3.0b3pre.
Status: RESOLVED → VERIFIED
Flags: in-litmus?
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h". In Thunderbird 3.0b, you do that as follows: Tools | Message Filters Make sure the correct account is selected. Click "New" Conditions: Body contains places-to-b-and-h Change the action to "Delete Message". Select "Manually Run" from the dropdown at the top. Click OK. Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter. Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: