Marco Zehe (:MarcoZ) Assignee
	Description • 17 years ago

In the Message Viewer (after opening a message using ENTER), the fields "From", "Date" etc. do not have associated labels.

	Marco Zehe (:MarcoZ) Assignee
	Comment 1 • 17 years ago

This patch is just an idea on how I'd go about creating the relationship between the label and textbox elements. This patch does not work yet, primarily because I am not sure:
1. How to create a unique ID.
2. If the properties I'm using are the right ones in the constructor.

Does anybody have any input to share? This would be greatly appreciated!

	Marco Zehe (:MarcoZ) Assignee
	Comment 2 • 17 years ago

As discussed with Neil on IRC, an alternative is to just use inheritance. However this does also not work. Neil, is this what it should look like in theory?

	Marco Zehe (:MarcoZ) Assignee
	Comment 3 • 17 years ago

This patch adds the accId attribute to the two mail widgets that are exposed as accessibles. This accId is translated into the id attribute for the relevant label anonymous element. It is also used for the aria-labelledby attribute for the xul:textbox. However the association does not work right yet. The accessible for the label is created, but it is not linked to the textbox. Aaron, can you see why?

	Marco Zehe (:MarcoZ) Assignee
	Comment 4 • 17 years ago

This patch adds ids to both the label and the textbox. Both are accessibles (the label is not without the id attribute). Yet they don't want to connect to one another. Neither using control on the label, nor using aria-labelledby on the textbox will make them connect to one another.

Aaron, any ideas on this?

	Aaron Leventhal
	Comment 5 • 17 years ago

The author shouldn't have to set these unique ID's -- the label association should just work.

The anonymous <textbox> already has an anonid="headerValue". All you should have to do is put control="headerValue" on the label element.

	Marco Zehe (:MarcoZ) Assignee
	Comment 6 • 17 years ago

This patch adds a label/textbox relationship to the mail widgets that are used for Subject, date etc. It also adds a couple control attributes for other labels inside the mail viewing window.

Thanks, Neil and Aaron, for all your help! In the end, it turned out to be rather simple...

	Marco Zehe (:MarcoZ) Assignee
	Comment 7 • 17 years ago

Requesting checkin of patch. Thanks!

	Reed Loden [:reed]
	Comment 8 • 17 years ago

Checking in mailnews/base/resources/content/mailWidgets.xml;
/cvsroot/mozilla/mailnews/base/resources/content/mailWidgets.xml,v  <--  mailWidgets.xml
new revision: 1.125; previous revision: 1.124
done
Checking in mailnews/base/resources/content/msgHdrViewOverlay.xul;
/cvsroot/mozilla/mailnews/base/resources/content/msgHdrViewOverlay.xul,v  <--  msgHdrViewOverlay.xul
new revision: 1.73; previous revision: 1.72
done