Open Bug 408725 Opened 17 years ago Updated 15 years ago

toolbarbutton icons move in :hover state w/o padding or margin change

Categories

(SeaMonkey :: Themes, defect)

defect
Not set
normal

Tracking

(Not tracked)

People

(Reporter: stefanh, Unassigned)

References

Details

Attachments

(1 file)

(deleted), application/vnd.mozilla.xul+xml
Details
This is the :hover version of bug 386629.

Note: you need to be on a OS where there are no padding/margin changes upon :hover (or just remove the hover/hover:active rules in communicator/win/button.css).

I think it's prefectly fine that the buttons move when hovering over them, provided that this is done with style rules. However, without any style rules this behavior can be observed:

Hovering over back/fwd/reload buttons --> movement to the right
Hovering over the print button --> movement to the left
Hovering over the Stop button --> movement to the right

I'm quite convinced that the current behavior is due to some positioning-glitches in suite/themes/classic/communicator/icons/communicatoricons.png
(In reply to comment #0)

> (or just remove the hover/hover:active rules in
> communicator/win/button.css).

Erm, I guess winstripe needs some hacking too :-/
So, I was looking at the back/fwd buttons in communicatoricons.png. It looks like border areas in :hover/:hover:active versions are different that the "normal" ones. The shadow is also different. This seems to cause the moving effect. I can't imagine that this was done by purpose - the print button moves in the opposite direction and there are buttons that doesn't move at all :-/
Interestingly, the hover:active icons seems to be made from the :hover ones. That's also the reason that I don't see any movement when switching between :hover and :hover:active
Attached file Testcase (deleted) β€”
Here's a testcase in order to demonstrate the issue. Note that since I use the image element it should work for win/nix users as well ;-)
Note that on mac we shouldn't really do anything on :hover. But not doing anything on :hover in this case would mean that the buttons moved on hover:active instead.

Btw, note the "Stop" button behaviour; darker upon :hover and lighter upon :hover:active.

Assignee: general → nobody
Component: General → Themes
QA Contact: general → themes
Depends on: 460699
I think I made this depend on the theme bug because I originally thought of using the default hove:active icons (and they behaved like the :hover ones). It turned out that I made new icons for the other-than-normal states and based them on the normal ones. So, this isn't an issue on mac classic anymore. The issue still exists on win/nix, though. However, I'm not sure win/nix cares about this since the correct behaviour is a "move".
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: