Closed
Bug 408821
Opened 17 years ago
Closed 15 years ago
Merge strings for IMAP_STATUS_SENDING_LOGIN and IMAP_STATUS_SENDING_AUTH_LOGIN
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: sgautherie, Assigned: sgautherie)
References
Details
Attachments
(1 obsolete file)
Copied from bug 300670 comment 8, per bug 300670 comment 12:
{{{
Scott MacGregor 2007-01-26 13:23:01 PST
On the trunk, I think it eventually makes sense to collapse the string for
IMAP_STATUS_SENDING_LOGIN and IMAP_STATUS_SENDING_AUTH_LOGIN into a single
string since right now in en-US they have the same value.
}}}
|
Assignee | |
Comment 1•17 years ago
|
||
Something like this ?
Untested.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #293668 -
Flags: superreview?(neil)
Attachment #293668 -
Flags: review?(mscott)
|
||
Comment 2•17 years ago
|
||
Comment on attachment 293668 [details] [diff] [review]
(Av1) Merge strings
> # Status - logging on
> ## @name IMAP_STATUS_SENDING_LOGIN
> ## @loc None
> 5013=Sending login information...
>
>-# Status - auth logon
>-## @name IMAP_STATUS_SENDING_AUTH_LOGIN
>-## @loc None
>-5014=Sending secure login information...
Except that right now we have different strings, and for good reason.
Attachment #293668 -
Flags: superreview?(neil) → superreview-
|
|
Assignee | |
Comment 3•17 years ago
|
||
I know... :-|
Would using some kind of "ifdef MOZ_SUITE" in the .h file instead help ?
Otherwise, what would be a solution to satisfy both of you ?
|
||
Comment 4•17 years ago
|
||
I don't think it's useful to "fix" it - these _are_ different kinds of logins. And the "harm" for TB in not having this "fixed" is very minimal...
|
||
Updated•16 years ago
|
Product: Core → MailNews Core
|
||
Comment 5•16 years ago
|
||
Comment on attachment 293668 [details] [diff] [review]
(Av1) Merge strings
mscott no longer actively reviewing, so canceling review as part of Patch Love
https://wiki.mozilla.org/Thunderbird:PatchLove
since sr- I assume someone has an idea what the next step is for this bug.
Attachment #293668 -
Flags: review?(mscott)
|
|
Assignee | |
Comment 6•15 years ago
|
||
R.WontFix, per comment 4.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → WONTFIX
Target Milestone: mozilla1.9beta3 → ---
|
|
Assignee | |
Updated•15 years ago
|
Attachment #293668 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•