Closed Bug 409287 Opened 17 years ago Closed 16 years ago

Report broken website tango icon

Categories

(Other Applications Graveyard :: Reporter, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: micmon, Assigned: ventnor.bugzilla)

References

Details

Attachments

(2 files, 2 obsolete files)

Attached file Tango icon (16, 24) + CSS (obsolete) (deleted) —
The "report broken website" button is the only button on the toolbar that does not yet use the tango style on linux. This is the tango version in 16x16 and 24x24, including the disabled states. Needs a proper patch for integration.
Attached patch Patch (obsolete) (deleted) — Splinter Review
Assignee: nobody → ventnor.bugzilla
Status: NEW → ASSIGNED
Attachment #297487 - Flags: review?(rflint)
FYI this stops Reporter from being a true extension (i.e. building the same chrome for all platforms).
Component: OS Integration → Reporter
Product: Firefox → Other Applications
QA Contact: os.integration → xul-client
(In reply to comment #2) > FYI this stops Reporter from being a true extension > (i.e. building the same chrome for all platforms). Indeed. Can we use a platform specific package here instead of the build-time ifdef?
Attached patch Patch 2 (deleted) — Splinter Review
Attachment #297487 - Attachment is obsolete: true
Attachment #298386 - Flags: review?(rflint)
Attachment #297487 - Flags: review?(rflint)
Comment on attachment 298386 [details] [diff] [review] Patch 2 >Index: browser/themes/gnomestripe/browser/browser.css >+#reporterMenuButton[disabled="true"] { >+ -moz-image-region: rect(24px 24px 48px 0px) !important; >+} >+toolbar[iconsize="small"] #reporterMenuButton[disabled="true"] { >+ -moz-image-region: rect(16px 16px 32px 0px) !important; >+} Reporter's an overlay, so you're going to lose the battle of the cascade to: http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/extensions/reporter/resources/skin/classic/reporter/browserOverlay.css&rev=1.3&mark=21,42#20 >Index: browser/themes/gnomestripe/browser/jar.mn Right? (wink, wink, nudge ;)) Looking at the icon, I'd say it's a fairly suitable replacement for all three platforms and would only require creating a hover state and overriding that in gnomestripe - Robert should probably weigh in on that though.
Attachment #298386 - Flags: review?(rflint) → review-
Blocks: 381206
Adding this to the icon inventory, we will try to get it on all platforms. As usual Team Penguin is in the lead :)
To match os x and the two windows themes, we would like the tango report site button added to the far right of /browser/themes/gnomestripe/browser/Toolbar.png
(In reply to comment #7) > To match os x and the two windows themes, we would like the tango report site > button added to the far right of > /browser/themes/gnomestripe/browser/Toolbar.png Are you sure that's the best way to go with fixing this issue? Seems very odd to be sticking the "Report Site" icon in Toolbar.png when reporter itself is an extension.
We aren't got to take away the report site icon, so the extension isn't dependent on the theme, but we also thought it made the most sense for each themes toolbar icons to be grouped together.
Gavin: can you confirm that this is the right thing to do, since reporter is an extension.
Attached file Updated toolbar images (deleted) —
Sorry for the delay. Here are the updated toolbar images featuring the bug icons (small and normal size)
Attachment #294099 - Attachment is obsolete: true
(In reply to comment #10) > Gavin: can you confirm that this is the right thing to do, since reporter is an > extension. It's an extension, but there's no problem with adding our own icon and overriding the extension-shipped one in our CSS.
Depends on: 430217
Setting this bug to wontfix since we decided to remove these icons from the toolbar customization palette
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → WONTFIX
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: