Closed Bug 40959 Opened 25 years ago Closed 24 years ago

[RFE] /names command should be implemented properly

Categories

(Other Applications :: ChatZilla, enhancement, P3)

x86
Linux
enhancement

Tracking

(Not tracked)

VERIFIED FIXED
Future

People

(Reporter: andreas.otte, Assigned: rginda)

References

Details

With current build 05-29-00 under linux the /names command does nothing but close the info bar.
Actually, that's all it's supposed to do at the moment.
Status: NEW → ASSIGNED
Summary: /names command closes info tree → [RFE] /names command should be implemented properly
mass marking chatzilla bugs future
Target Milestone: --- → Future
*MASS SPAM* Changing QA contact on all open or unverified ChatZilla bugs to me, David Krause, as I am now the QA contact for this component.
QA Contact: rginda → David
Depends on: 71468
superbug checked in, mass marking all dependents fixed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Hi, so far as I can tell, /names doesn't work in server view (that is, the view one gets after connecting to a server, if my terminology is wrong). It does work in the channel view, if I've joined a channel. executing /names on moznet, server view: /names #chatzilla result: nothing. expected: list of names on #chatzilla. executing /names on moznet, #chatzilla, channel view: /names #chatzilla result: list of names. I'm using 0.8.5 pre23, running on mozilla Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.5+) Gecko/20011108, but I've seen this same issue on a more recent nightly on WinXP Pro as well (about a week old, but I don't have access to that machine at the moment so I can't tell you the exact build). Aside from this issue, I'm really digging pre23. Thanks.
I've browsed the source a bit, and so far as I can tell, this turns out to be a feature. :( I can't really test my guess at the moment, as I'm on a machine without mozilla installed, but I'll know for sure when I get home and can test my suspicion. Look at http://lxr.mozilla.org/mozilla/source/extensions/irc/xul/content/handlers.js#1517 I think what that does is basically refusing to list /names for a channel unless one is currently in a channel 'view'. Why is this done? I tend to use the /names command only from the 'server views' in other IRC clients, because when I use it I'm interested in seeing who's on a particular channel, but I don't feel sociable enough to actually join the channel. This is particularly true when I'm looking for some particular user who I'd like to talk to. So having the capability to do a /names from a server view is somewhat important to me. If it's an intentional feature, and needs to be that way for some reason, I'll cope =) (I can always change it to be the way _I_ like it on my local install). So, why is that check performed? Is it part of some RFC or something like that? Cheers
The problem is that the output from /names is sent to the window of the channel you are checking, so if you don't have the channel open, you don't see anything. I would consider that to be a bug. That line you pointed out only applies when you don't give a parameter to the /names command, in which case it determines which channel to check by where you are. If you aren't in a channel, the command doesn't make sense. Feel free to file a new bug on what I've said, or just wait a bit, it's on my list of things to fix.
Status: RESOLVED → VERIFIED
QA Contact: mozilla → samuel
[RFE] is deprecated in favor of severity: enhancement. They have the same meaning.
Severity: normal → enhancement
Product: Core → Other Applications
You need to log in before you can comment on or make changes to this bug.