User-Agent: Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9b3pre) Gecko/2007123110 Fedora/8 (Werewolf) Minefield/3.0b3pre Build Identifier: Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9b3pre) Gecko/2007123110 Fedora/8 (Werewolf) Minefield/3.0b3pre some widgets, like close button in "no updates found" info have non-gtk focus drawn, which look odd and very out-of-place. Reproducible: Always Steps to Reproduce: 1. you must have no update for extensions :> . 2. click "find updates". 3. click close button on info, without getting mouse button up and that button (to prevent closing info message). Actual Results: close button has additional focus. Expected Results: everything ok (with firefox it's a wish for christmas...).

This part of code was added with bug 281932, but it is not needed for GTK toolbar buttons (a double focus ring is also painted for print preview toolbar buttons in Firefox 2). With this patch the buttons in the print preview toolbar remain accessible with the keyboard and focus is being drawn (natively).

ping

Extra focus rings look really bad. :(

Ryan, do you have cycles to review this if Mano is too busy?

Reed, did you posted comment #4 in good bug?

(In reply to comment #5) > Reed, did you posted comment #4 in good bug? The comment was meant for this bug, yes.

Hmmm, close buttons in "No updates find" tip in addons manager also have double focus indicator (GTK's and Firefox').

Comment on attachment 295898 [details] [diff] [review] remove redundant drawing of focus myk or michael should review this. mpa=me.

Comment on attachment 295898 [details] [diff] [review] remove redundant drawing of focus Good catch! This fix works great. r=myk

Checking in toolkit/themes/gnomestripe/global/toolbarbutton.css; /cvsroot/mozilla/toolkit/themes/gnomestripe/global/toolbarbutton.css,v <-- toolbarbutton.css new revision: 1.17; previous revision: 1.16 done

Verified on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9) Gecko/2008060309 Firefox/3.0 Seeing nothing out of place anymore :)

@Paul: ugly dotted focus on tabs labels still remain.

Jakub, please file a followup on remaining issues.