Michael Monreal [:micmon] Reporter
	Description • 17 years ago

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.8) Gecko/20071022 Ubuntu/7.10 (gutsy) Firefox/2.0.0.8
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007112004 Minefield/3.0b2pre

Open FF3 and open the bookmark sidebar. press the close button, but drag the mouse down to the bookmarks so that the sidebar stays open (release mouse). Now, click either into the white area of the bookmarks or move directly back up and hover over the close button. It turns to "pressed" now instead of the normal hover state!

Also, the button seems to draw two focus rings, which is ugly (it should draw no focus ring at all).

Reproducible: Always

	Michael Monreal [:micmon] Reporter
	Comment 1 • 17 years ago

This shows the states of the close button... the correct hover, the incorrect hover and a pressed state (this actually has another focus ring inside but for what ever reason I cannot screenshot it).

	Elmar Ludwig
	Comment 2 • 17 years ago

Confirming on a current Linux nightly build. This probably needs to be reassigned, but I'm not sure where it belongs (Toolkit/XUL Widgets?).

	Michael Monreal [:micmon] Reporter
	Comment 3 • 17 years ago

This also affects the back and forward buttons in the find bar.

	Michael Monreal [:micmon] Reporter
	Comment 4 • 17 years ago

The button is also not square... and the icon gets stretched and deformed on it.

	Michael Monreal [:micmon] Reporter
	Comment 5 • 17 years ago

(In reply to comment #4)
> The button is also not square... and the icon gets stretched and deformed on
> it.

This has been fixed. 

The rest of the bug, though, has not been fixed. Also affected is the "hilight all" button on the find bar btw.

	Teune van Steeg
	Comment 6 • 17 years ago

(In reply to comment #5)
> (In reply to comment #4)
> > The button is also not square... and the icon gets stretched and deformed on
> > it.
> 
> This has been fixed. 
> 
> The rest of the bug, though, has not been fixed. Also affected is the "hilight
> all" button on the find bar btw.
> 

The extra focus rings is currently handled in bug 410789.

	u294409
	Comment 7 • 17 years ago

Mark as RESOLVED:FIXED.

	Elmar Ludwig
	Comment 8 • 17 years ago

(In reply to comment #7)
> Mark as RESOLVED:FIXED.

No, the main issue of this bug (see comment #0) is not fixed yet.

	u294409
	Comment 9 • 17 years ago

[[ It turns to "pressed" now instead of the
normal hover state! ]]

It's native GTK behavior!
I did the same in GNOME-Main-Menu applet, in `gnome-session-save --kill` dialog and in more and more native GTK places.

Bug is invalid.

	u294409
	Comment 10 • 17 years ago

Press Escape. "Strange" behaviour will move away...

	Elmar Ludwig
	Comment 11 • 17 years ago

(In reply to comment #9)
> It's native GTK behavior!

No, and I definitely don't see this in any other GTK application.

This is basically the same issue as was reported for the bookmarks toolbar in bug 225434, just in a different place in the UI. The drop down menus for the back and forward buttons and the new, native location bar drop down button all show the same problem as well, by the way.

	Michael Monreal [:micmon] Reporter
	Comment 12 • 17 years ago

Jakub, Elmar is right. In fact this remaining bug is harder to see now, in normal usage it's not very visible. Can probably be marked as a duplicate to bug 225434 as this one is more specific.

	u294409
	Comment 15 • 17 years ago

The icon in current Trunk is cropped.

	Michael Monreal [:micmon] Reporter
	Comment 16 • 17 years ago

(In reply to comment #15)
> The icon in current Trunk is cropped.
> 

What icon theme?

	u294409
	Comment 17 • 17 years ago

Tango Generator-generated. Close icon is inherited at all sizes from gnome-icon-theme from SVN and from hicolor.

	Michael Monreal [:micmon] Reporter
	Comment 18 • 17 years ago

Hmm... what gtk theme? Can you attach a screenshot?

	u294409
	Comment 19 • 17 years ago

Clearlooks, Glossy (Clearlooks engine from SVN), Nodoka, Rezlooks-Charamel...

"It doesn't matter", as Petra Marklund (September) sings (; .

	Michael Monreal [:micmon] Reporter
	Comment 22 • 7 years ago

No longer relevant with Photon theme.