While working on bug 8415 I came across some gifs in chrome/skins/modern/navigator/skin that should be removed. alertl.gif , errorl.gif , messagel.gif , questionl.gif These images are all in chrome/skins/modern/global as alert-icon.gif , error-icon.gif , message-icon.gif , question-icon.gif and are redundant. home.gif , location.gif , location-hover.gif , mynetscape.gif , print.gif , search.gif Are left overs from last years classic UI. n-box-persbar.gif I'm not sure if this one is still used, but if it is, it belongs in the global directory.

not sure what component this belongs under

--> XPApps (at a guess)

To test this I installed one of the nightlys in a seprate directry last night, and removed these files. I used that copy for hours. No bugs were introduced by removing these files.

These gifs also appear in the new classic skin. some of them have been updated but still aren't being used. Are they for future plans?

->skinability?

ben, are these indeed redundant and not being used?

Updating summary What was the modern skin when I filed this bug is now the Blue skin. The Classic skin has inherited the unused gifs. The New Modern skin still has the old images in it. The Classic skin still has the images used for the Blue skin's background and buttons in the global directory. That just covers the images I saw on a quick scan. When I created the Neoclassic skin (http://x.themes.org) I based it on the Classic theme. I found many images that weren't called by any of the css files and eliminated them. I'm sure that a through check would reveal other excess images in all 3 skins.

nominating for beta3. Finding out which images aren't used and removing them would be a trivial task, and would help reduce the app size.

The test xpi is the classic skin, build 82908 Windows, with all gifs deleated that aren't called by a css file. The other file is the gifs I removed. 170 of them total 62.3 kb Even more savings can be made by getting rid of duplicate images. For example there are 4 stop gifs in the navigator directory used by navigator.css. The same 4 gifs are in the global directory and used by messenger and messengercompose. Also see related bug 45008. it deals with optimizing the gifs that remain so they are smaller.

nav traige team:nsbeta3-, but this shouldn't stop non-netscape contributors with module owner approval right?

this deals with removing images from specific themes. ->themes

If someone has the ability to identify images in the skins that are not used and remove them from the tree I would support that. I am the component owner for the Themes and also the skin reviewer. If someone can show me how they can do this safely I will plus the bug and give approval. To speed things along please contact me directly by email, I am very behind in my bug list.

I have written a script to identify the files that are present in cvs, but are not referenced anywhere in the css. This will be a pretty good start towards getting rid of these images.

I would suggest removing the unused images from the Blue theme's make files as a test case. That way if any problems are encountered they won't affect the themes most people are using. If no problems are found with Blue, then Modern and Classic's make files can be cleaned up, and last of all the extra images can be removed from CVS.

Themes Triage Team nsbeta1+

*** Bug 51314 has been marked as a duplicate of this bug. ***

Modern has been cleansed. Classic still needs a scrubbing.

Themes Triage Team Marking nsbeta1-

Mass reassigning some of my theme bugs to Shuehan.

The hard work here is making the list for Classic. If that's done, someone can come along and cvs remove the files. Gerv

I believe someone just checkin the last day or two.. removing the blue icons in classic skin?

hewitt checked in a bunch of cleanup/re-write code here in 12-19-01 build.. but it appears he removed the respin image for tab browsing.. and the perf panel > mail & newsgroups > both message pane perf images are missing.. either that, the panel cannot display them.

12-20, mail & newsgroups images are there. so re-spin image is still missing from tabs.

note: filed a new bug on classic: respin missing from tabs using tab browsing: see bug 116905.

shliang, was your patch ever checked in?

what's the status of this bug? a patch is provided, though it doesn't look like that r/sr has ever been asked.

After some research, I believe this bug has become invalid.

Why? server-local-new.gif, for example, is only referenced in some jar.mn files.

Ignoring the patch, I can't find reference to any of the files mentioned.

Why are you ignoring the patch? I also don't agree with marking the bug as INVALID, rather it should be marked as WFM or FIXED - that is, if all redundant images are removed from the classic skin.

OK, my mistake, I should have read comment #7 more carefully. Reopening. The patch needs work. Any volunteers?

This bug is ancient, if anything like this is still valid, please file specific bugs on specific part or images.