The urlbar "star" in the mac theme is grey now. This is very odd, especially when visiting HTTPS sites: now when visiting an unbookmarked HTTPS site, the inside of the star is yellow, which on other OSes would mean a "bookmarked site". This is confusing when I switch from other OSes which use a yellow star to mean "bookmarked"... and on the web most stars are yellow. I know that we're going for the colorless macos vibe, but I really think we should stick with a white star for "unbookmarked" and a yellow star for "bookmarked".

I agree. "Hollow with white" vs. "Filled with black" is not an intuitive "on versus off" decision; in fact, when I first saw the new interface, I thought that black=off like a light switch (i.e., no bookmark had been set). On Windows, "White" versus "Yellow" is very clear. Additionally, the star is often displayed next to the RSS symbol, which is orange. Therefore, color is acceptable in that portion of the interface.

Note: bug 392427 is about fixing the transparent background, so that you don't see yellow when visiting unstarred HTTPS sites.

While I'm minusing the blocking request, I do agree that the grey star treatment seems a little strange at the moment, and wonder if a blue might not work better.

I think this is only likely to confuse people who move between operating systems. I agree with Mike that if we were to use a color, it would need to be blue.

The actual color isn't all that important to me. What's important is that I can tell whether the star is "on" or "off" at a glance. I still get confused all the time whether the open star means a page is starred or not.

this is blue now and very open feeling when not activated. are we going to revisit this or is it "done" for ff3?

I think we are pretty much done, although we should add a white outline for when the blue star is on a blue selection background.

fixed by checkin of bug 430202

Verified with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008050209 Minefield/3.0pre ID:2008050209