various UI glitch fixes and icon updated

Comment on attachment 316942 [details] [diff] [review] Patch against trunk. See Proto 0.17.1 theme on AMO to test note on the patch: I added some rules to global.css to style buttons on the notification bar. The rules wouldn't take in notification.css. If I should move the rules out of global.css, how can I select the buttons?

addressed issues froms bug 415957 and 415978

Kevin, any chance you could fix the appearance of the selected-item in *unfocused* trees here?

(In reply to comment #3) > Kevin, any chance you could fix the appearance of the selected-item in > *unfocused* trees here? > In the sidebars? Yeah, I'll investigate as soon as I can.

in the sidebar, in the bookmarking dialog, and in the organizer.

Comment on attachment 316955 [details] [diff] [review] patch v2 >RCS file: /cvsroot/mozilla/toolkit/themes/pinstripe/global/findBar.css,v >retrieving revision 1.11 . . . >-.findbar-closebutton { >+.findbar-container > .findbar-closebutton { . . . > /* find-next button */ > >-.findbar-find-next { >+.findbar-container > .find-buttons-container > .findbar-find-next { . . . >-.findbar-find-previous { >+.findbar-container > .find-buttons-container > .findbar-find-previous { LXR tells me that these only exists in one place (/toolkit/content/widgets/findbar.xml), so you shouldn't need the child selectors.

addresses Stefan's comment and adds sidebar styles. Proto 0.17.3 was uploaded to AMO containing these changes

Kevin, see comment 5 please.

Never mind.

Actually, Isee it fixed in 0.17.3, but code-wise, the class set on the tree is different in the organizer (placesTree, not sidebar-placesTree), so how is this fixed (in the patch)?

(In reply to comment #10) > Actually, Isee it fixed in 0.17.3, but code-wise, the class set on the tree is > different in the organizer (placesTree, not sidebar-placesTree), so how is this > fixed (in the patch)? I used #placesList for the organizer sidebar, because the placesTree class can refer to both the sidebar and the main content trees in the organizer.

Then it should be in organizer.css.

(In reply to comment #12) > Then it should be in organizer.css. > good point. moved. want a new patch?

Comment on attachment 317048 [details] [diff] [review] Patch v3 no, r=mano.

Comment on attachment 317048 [details] [diff] [review] Patch v3 re-request approval once reviews are completed.

Comment on attachment 317048 [details] [diff] [review] Patch v3 ok, re-requesting approval

landed patch and changed/additional images on trunk

this fixed https://bugzilla.mozilla.org/show_bug.cgi?id=427780 however, I tested proto 0.17.3 on AMO, which causes color mismatch again with "small icons" when bookmark toolbar is disabled. Is that 0.17.3 an older version (hopefully, since this one looks perfect and better than 0.17.3)?

Not sure if the extra line at the bottom of the download manager is from .17 changes.. might be from the extra clear list button. But the button itself might need to be styled. Perhaps its margins are too big (set margin-top/bottom to 0 and let align center handle it?)

All depending bugs are fixed. Lets verify this tracking bug.